Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] use tmp_path in tests for first lvl GLM #3894

Merged
merged 3 commits into from Aug 9, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 5, 2023

@github-actions
Copy link
Contributor

github-actions bot commented Aug 5, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@bthirion
Copy link
Member

bthirion commented Aug 5, 2023

LMK when it deserves a review.

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Aug 5, 2023

LMK when it deserves a review.

not before #3892 is in because this PR depends on it

@Remi-Gau Remi-Gau removed the Blocked label Aug 7, 2023
@Remi-Gau Remi-Gau marked this pull request as ready for review August 7, 2023 13:36
@codecov
Copy link

codecov bot commented Aug 7, 2023

Codecov Report

Merging #3894 (8b56003) into main (d4fec68) will decrease coverage by 0.07%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #3894      +/-   ##
==========================================
- Coverage   91.60%   91.53%   -0.07%     
==========================================
  Files         134      134              
  Lines       15751    15751              
  Branches     3281     3281              
==========================================
- Hits        14429    14418      -11     
- Misses        772      784      +12     
+ Partials      550      549       -1     
Flag Coverage Δ
macos-latest_3.10 91.53% <ø> (ø)
macos-latest_3.11 91.53% <ø> (ø)
macos-latest_3.8 91.49% <ø> (ø)
macos-latest_3.9 91.49% <ø> (ø)
ubuntu-latest_3.10 91.53% <ø> (ø)
ubuntu-latest_3.11 91.53% <ø> (ø)
ubuntu-latest_3.8 91.49% <ø> (ø)
ubuntu-latest_3.9 91.49% <ø> (ø)
windows-latest_3.10 91.47% <ø> (ø)
windows-latest_3.11 91.47% <ø> (ø)
windows-latest_3.8 91.43% <ø> (ø)
windows-latest_3.9 91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Remi-Gau

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Aug 9, 2023

Thanks @ymzayek

@Remi-Gau Remi-Gau merged commit 6fe4c71 into nilearn:main Aug 9, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the tmp_path_first_lvl branch August 29, 2023 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants