Revert breaking behavior in plot_glass_brain
#3924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3924 +/- ##
=======================================
Coverage 91.76% 91.76%
=======================================
Files 134 134
Lines 15747 15747
Branches 3283 3283
=======================================
Hits 14451 14451
Misses 752 752
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Remi-Gau
reviewed
Aug 23, 2023
|
|
||
|
|
||
| def test_plot_glass_brain_vmin_vmax(mni_3d_img): | ||
| """Smoke tests for plot_glass_brain beaing passed vmin and vmax.""" |
There was a problem hiding this comment.
Suggested change
| """Smoke tests for plot_glass_brain beaing passed vmin and vmax.""" | |
| """Smoke tests for plot_glass_brain beaing passed vmin and vmax.""" |
being + breaking = beaing ? 😉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
plot_glass_brainbehavior to silently ignorevmin#3923Changes proposed in this pull request:
vminargument toplotting.plot_img_on_surf#3873