New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Expose standardize
parameter in function signatures to allow handling of deprecation
#3927
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3927 +/- ##
==========================================
- Coverage 91.76% 91.75% -0.02%
==========================================
Files 134 134
Lines 15747 15751 +4
Branches 3283 3283
==========================================
+ Hits 14451 14453 +2
- Misses 752 753 +1
- Partials 544 545 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 4 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far, but we need to check that the behavior of the examples is still fine.
Showing main branch build versus changes in this PR for affected examples: plot_carpet: main version vs this pr plot_atlas_comparison: main version vs this pr plot_extract_regions_dictlearning_maps: main version vs this pr plot_group_level_connectivity: main version vs this pr plot_probabilistic_atlas_extraction: main version vs this pr plot_signal_extraction: main version vs this pr plot_sphere_based_connectome: main version vs this pr plot_age_group_prediction_cross_val: main version vs this pr |
Is there a reason that standardize_confounds was not passed to RegionExtractor? |
Thx ! LGTM |
No, I think it was simply forgotten. |
had a look yesterday and it LGTM |
Ok should be good to go once the CI passes |
Changes proposed in this pull request:
plot_carpet
andConnectivityMeasure
so users can deal with "zscore" deprecation