Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] refactor design matrix tests #3939

Merged
merged 4 commits into from Aug 31, 2023
Merged

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Aug 30, 2023

Changes proposed in this pull request:

  • refactor tests for design matrix and experimental paradigm

@github-actions
Copy link
Contributor

github-actions bot commented Aug 30, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Merging #3939 (2b46384) into main (c859e91) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3939   +/-   ##
=======================================
  Coverage   91.77%   91.77%           
=======================================
  Files         134      134           
  Lines       15751    15751           
  Branches     3283     3283           
=======================================
  Hits        14455    14455           
  Misses        752      752           
  Partials      544      544           
Flag Coverage Δ
macos-latest_3.10 91.68% <ø> (ø)
macos-latest_3.11 91.68% <ø> (ø)
macos-latest_3.8 91.64% <ø> (ø)
macos-latest_3.9 91.64% <ø> (ø)
ubuntu-latest_3.10 91.68% <ø> (ø)
ubuntu-latest_3.11 91.68% <ø> (ø)
ubuntu-latest_3.8 91.64% <ø> (ø)
ubuntu-latest_3.9 91.64% <ø> (ø)
windows-latest_3.10 91.62% <ø> (ø)
windows-latest_3.11 91.62% <ø> (ø)
windows-latest_3.8 91.59% <ø> (ø)
windows-latest_3.9 91.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM otherwise.

nilearn/glm/tests/test_dmtx.py Outdated Show resolved Hide resolved
nilearn/glm/tests/test_dmtx.py Outdated Show resolved Hide resolved
@Remi-Gau Remi-Gau merged commit f0852e1 into nilearn:main Aug 31, 2023
29 checks passed
@Remi-Gau Remi-Gau removed the Blocker label Aug 31, 2023
@Remi-Gau Remi-Gau deleted the events_0 branch August 31, 2023 01:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

refactoring suggestions for some glm tests
2 participants