New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] improve section on private functions #3952
Conversation
Remi-Gau
commented
Sep 6, 2023
- Closes improve summary in contribution documentation regarding private "functions" #3947
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #3952 +/- ##
==========================================
+ Coverage 91.78% 91.79% +0.01%
==========================================
Files 134 134
Lines 15772 15772
Branches 3284 3284
==========================================
+ Hits 14476 14478 +2
+ Misses 752 751 -1
+ Partials 544 543 -1
Flags with carried forward coverage won't be shown. Click here to find out more. see 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This makes it more explicit. Thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's better thanks!
I just copy pasted @jeromedockes words so he should get the credit on this one |