Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MAINT] add consortium authorship #3969

Merged
merged 1 commit into from Sep 13, 2023
Merged

[MAINT] add consortium authorship #3969

merged 1 commit into from Sep 13, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Sep 12, 2023 •
edited

Changes proposed in this pull request:

  • makes sure that scripts in charge of citation.cff curation always keep the consortium author at the top of the list of authors in the citation.cff.

Remi-Gau
Remi-Gau commented Sep 12, 2023
View reviewed changes
AUTHORS.rst
@@ -137,7 +137,7 @@ Some other past or present contributors are:
* `Maximilian Cosmo Sitter`_
* `Mehdi Rahim`_: Air Liquide, France
* `Michael Eickenberg`_: Flatiron Institute, New-York, New-York, USA
* `Michael Hanke`_: Psycho­informatics, Forschungszentrum Jülich GmbH, Jülich, Germany
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removes a character with some "weird" encoding that made my VS code lose its mind

Remi-Gau
Remi-Gau commented Sep 12, 2023
View reviewed changes
CITATION.cff
@@ -27,6 +27,7 @@ contact:
license: BSD-4-Clause

authors:
- family-names: Nilearn contributors
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@emdupre I went with the first thing that crossed my mind but happy to use anything else.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fine ! I'd say "developers", but I don't think this word choice is going to make or break the consortium idea :)

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think so either. And we still have some time before the release in case we got a change of heart

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 12, 2023 •
edited

Codecov Report

Merging #3969 (0568916) into main (93c49f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3969   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         134      134           
  Lines       15772    15772           
  Branches     3284     3284           
=======================================
  Hits        14478    14478           
  Misses        751      751           
  Partials      543      543
Flag Coverage Δ
macos-latest_3.10 91.70% <ø> (ø)
macos-latest_3.11 91.70% <ø> (ø)
macos-latest_3.8 91.67% <ø> (ø)
macos-latest_3.9 91.67% <ø> (ø)
ubuntu-latest_3.10 91.70% <ø> (ø)
ubuntu-latest_3.11 91.70% <ø> (ø)
ubuntu-latest_3.8 91.67% <ø> (ø)
ubuntu-latest_3.9 91.67% <ø> (ø)
windows-latest_3.10 91.64% <ø> (ø)
windows-latest_3.11 91.64% <ø> (ø)
windows-latest_3.8 91.61% <ø> (ø)
windows-latest_3.9 91.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

bthirion
bthirion approved these changes Sep 12, 2023
View reviewed changes
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

ymzayek
ymzayek approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emdupre
emdupre approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Remi-Gau !

@Remi-Gau Remi-Gau merged commit 7fb097b into nilearn:main Sep 13, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the contrib_order branch September 19, 2023 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bthirion bthirion bthirion approved these changes

@emdupre emdupre emdupre approved these changes

@ymzayek ymzayek ymzayek approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[DOC] order of contributors
4 participants
@Remi-Gau @bthirion @emdupre @ymzayek