Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix rendering of explanatory text #3972

Merged
merged 1 commit into from Sep 14, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Sep 13, 2023

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Merging #3972 (1916242) into main (93c49f1) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   91.79%   91.79%           
=======================================
  Files         134      134           
  Lines       15772    15772           
  Branches     3284     3284           
=======================================
  Hits        14478    14478           
  Misses        751      751           
  Partials      543      543           
Flag Coverage Δ
macos-latest_3.10 91.70% <ø> (ø)
macos-latest_3.11 91.70% <ø> (ø)
macos-latest_3.8 91.67% <ø> (ø)
macos-latest_3.9 91.67% <ø> (ø)
ubuntu-latest_3.10 91.70% <ø> (ø)
ubuntu-latest_3.11 91.70% <ø> (ø)
ubuntu-latest_3.8 91.67% <ø> (ø)
ubuntu-latest_3.9 91.67% <ø> (ø)
windows-latest_3.10 91.64% <ø> (ø)
windows-latest_3.11 91.64% <ø> (ø)
windows-latest_3.8 91.61% <ø> (ø)
windows-latest_3.9 91.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bthirion
Copy link
Member

LGTM, but the documentation was not generated ?
Is there any other example that needs that ?

@ymzayek
Copy link
Member Author

ymzayek commented Sep 14, 2023

LGTM, but the documentation was not generated ?

Hm yes I'm not sure why but sometimes circleci times out or gets cancelled probably because of too many requests and resource limitations

Is there any other example that needs that ?

No this is mainly dealing with changing this:

image

To:

image

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me

@Remi-Gau Remi-Gau merged commit d1fadd4 into nilearn:main Sep 14, 2023
28 checks passed
@ymzayek ymzayek deleted the fix-example-text branch September 15, 2023 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants