-
Notifications
You must be signed in to change notification settings - Fork 575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Allow setting vmin
in plot_glass_brain
and plot_stat_map
#3993
Merged
Merged
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
9b4ba9e
add vmin to plot_glass_brain
michellewang 943033a
update thresholding
michellewang e26c79e
add test for plot_glass_brain
michellewang df374fb
update _get_colorbar_and_data_ranges() and tests
michellewang bf597fa
use half of colormap if plot_abs is True
michellewang 6d121f6
update docstrings
michellewang 65a518f
fix plot_abs and nan vmin/vmax
michellewang 0f49ef7
minor refactoring
michellewang 7da66f1
add example with vmin
michellewang 070d724
fix flake8 and do thresholding after transform_to_2d
michellewang 174366e
update example
michellewang 751d054
attempt to increase test coverage
michellewang 1c3bb48
Merge branch 'main' into 3084/more_vmin
michellewang 35f73d4
add changelog entry
michellewang 8dff80f
Merge branch 'main' into 3084/more_vmin
michellewang d420580
move default="auto" for symmetric_cbar to substitution string
michellewang 10c1ff0
remove redundant absolute value transformation
michellewang fdfbb9f
Merge remote-tracking branch 'upstream/main' into 3084/more_vmin
michellewang a082c03
attempt to increase test coverage
michellewang 3a9b38e
update docs for symmetric_cbar
michellewang a49efe8
replace error with warning for plot_abs/vmin case
michellewang 56ab1f9
Merge remote-tracking branch 'upstream/main' into 3084/more_vmin
michellewang b04548e
allow arbitrary vmin even if plot_abs is True
michellewang c45e8cd
Apply suggestions from code review
58f717d
Merge branch 'main' into HEAD
File filter
Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.