New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Make black CI more verbose #4008
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
black --check --diff --color .
shell: /usr/bin/bash -e {0}
env:
pythonLocation: /opt/hostedtoolcache/Python/3.11.5/x64
PKG_CONFIG_PATH: /opt/hostedtoolcache/Python/3.11.5/x64/lib/pkgconfig
Python_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
Python2_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
Python3_ROOT_DIR: /opt/hostedtoolcache/Python/3.11.5/x64
LD_LIBRARY_PATH: /opt/hostedtoolcache/Python/3.11.5/x64/lib
--- /home/runner/work/nilearn/nilearn/nilearn/plotting/img_plotting.py 2023-09-25 09:32:05.952337+00:00
+++ /home/runner/work/nilearn/nilearn/nilearn/plotting/img_plotting.py 2023-09-25 09:32:14.617086+00:00
@@ -50,21 +50,25 @@
This function is equivalent to :func:`matplotlib.pyplot.show`,
but is skipped on the 'Agg' backend where it has no effect other
than to emit a warning.
"""
would reformat /home/runner/work/nilearn/nilearn/nilearn/plotting/img_plotting.py
- if matplotlib.get_backend().lower() != 'agg': # avoid warnings
+ if matplotlib.get_backend().lower() != "agg": # avoid warnings
plt.show()
|
Codecov Report
@@ Coverage Diff @@
## main #4008 +/- ##
=======================================
Coverage 91.77% 91.77%
=======================================
Files 134 134
Lines 15795 15795
Branches 3299 3299
=======================================
Hits 14496 14496
Misses 755 755
Partials 544 544
Flags with carried forward coverage won't be shown. Click here to find out more. 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
compute_fixed_effects
#3203 (comment)Changes proposed in this pull request: