Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.10.2 #4014

Merged
merged 7 commits into from Sep 29, 2023
Merged

Release 0.10.2 #4014

merged 7 commits into from Sep 29, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Sep 27, 2023

  • Closes none

To be merged after:

EDIT

To do after merge:

  • create a new doc/changes/latest.rst

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Sep 27, 2023

Codecov Report

Merging #4014 (392fe05) into main (9133bd9) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4014   +/-   ##
=======================================
  Coverage   91.73%   91.73%           
=======================================
  Files         145      145           
  Lines       16230    16230           
  Branches     3367     3367           
=======================================
  Hits        14888    14888           
  Misses        797      797           
  Partials      545      545           
Flag Coverage Δ
macos-latest_3.10 91.65% <ø> (ø)
macos-latest_3.11 91.65% <ø> (ø)
macos-latest_3.8 91.61% <ø> (ø)
macos-latest_3.9 91.61% <ø> (ø)
ubuntu-latest_3.10 91.65% <ø> (ø)
ubuntu-latest_3.11 91.65% <ø> (ø)
ubuntu-latest_3.8 91.61% <ø> (ø)
ubuntu-latest_3.9 91.61% <ø> (ø)
windows-latest_3.10 91.59% <ø> (ø)
windows-latest_3.11 91.59% <ø> (ø)
windows-latest_3.8 91.55% <ø> (ø)
windows-latest_3.9 91.56% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ymzayek
Copy link
Member

ymzayek commented Sep 27, 2023

create a new doc/changes/latest.rst

Just a note, we should do this in the post release and remove it from the include in whatsnew.rst in this PR. Once this is merged we'll tag it with the release version and build the stable docs from that and we don't want an empty dev header in that.

@ymzayek
Copy link
Member

ymzayek commented Sep 27, 2023

make Zenodo sync is enabled: #3963

It should be good but let's verify together tomorrow. Can also look at how to transfer the permissions

@Remi-Gau
Copy link
Collaborator Author

create a new doc/changes/latest.rst

Just a note, we should do this in the post release and remove it from the include in whatsnew.rst in this PR. Once this is merged we'll tag it with the release version and build the stable docs from that and we don't want an empty dev header in that.

ah yeah will make that clear in the TODO

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@Remi-Gau Remi-Gau marked this pull request as ready for review September 29, 2023 09:29
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go when the CI passes

@Remi-Gau
Copy link
Collaborator Author

Good to go when the CI passes

I am afraid to type those words now: it may just jinx it.

@Remi-Gau Remi-Gau merged commit 960589c into nilearn:main Sep 29, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the REL-0.10.2 branch November 9, 2023 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants