New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] drop python 3.7 #4033
[MAINT] drop python 3.7 #4033
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4033 +/- ##
==========================================
- Coverage 91.60% 91.59% -0.02%
==========================================
Files 143 143
Lines 16096 16086 -10
Branches 3347 3346 -1
==========================================
- Hits 14745 14734 -11
Misses 804 804
- Partials 547 548 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@@ -41,7 +40,7 @@ license = {text = "new BSD"} | |||
maintainers = [{name = "Bertrand Thirion", email = "bertrand.thirion@inria.fr"}] | |||
name = "nilearn" | |||
readme = "README.rst" | |||
requires-python = ">=3.7" | |||
requires-python = ">=3.8" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure we should already deprecate Python 3.8 ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure either. 3.8 reaches EOL in October next year. We can discuss in the coredev meeting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Changes proposed in this pull request: