Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] drop python 3.7 #4033

Merged
merged 4 commits into from Oct 25, 2023
Merged

[MAINT] drop python 3.7 #4033

merged 4 commits into from Oct 25, 2023

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 7, 2023

Changes proposed in this pull request:

  • drop python 3.7 and update CI and tests accordingly

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4033 (e9fabe4) into main (0260648) will decrease coverage by 0.02%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4033      +/-   ##
==========================================
- Coverage   91.60%   91.59%   -0.02%     
==========================================
  Files         143      143              
  Lines       16096    16086      -10     
  Branches     3347     3346       -1     
==========================================
- Hits        14745    14734      -11     
  Misses        804      804              
- Partials      547      548       +1     
Flag Coverage Δ
macos-latest_3.10 91.50% <ø> (+<0.01%) ⬆️
macos-latest_3.11 91.50% <ø> (+<0.01%) ⬆️
macos-latest_3.12 91.50% <ø> (+<0.01%) ⬆️
macos-latest_3.8 ?
macos-latest_3.9 91.47% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.10 91.50% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.11 91.50% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.12 91.50% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.8 ?
ubuntu-latest_3.9 91.47% <ø> (+<0.01%) ⬆️
windows-latest_3.10 91.45% <ø> (+<0.01%) ⬆️
windows-latest_3.11 91.45% <ø> (+<0.01%) ⬆️
windows-latest_3.12 91.45% <ø> (+<0.01%) ⬆️
windows-latest_3.9 91.41% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nilearn/__init__.py 55.55% <ø> (-23.40%) ⬇️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@@ -41,7 +40,7 @@ license = {text = "new BSD"}
maintainers = [{name = "Bertrand Thirion", email = "bertrand.thirion@inria.fr"}]
name = "nilearn"
readme = "README.rst"
requires-python = ">=3.7"
requires-python = ">=3.8"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure we should already deprecate Python 3.8 ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure either. 3.8 reaches EOL in October next year. We can discuss in the coredev meeting

@Remi-Gau Remi-Gau marked this pull request as ready for review October 24, 2023 17:39
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau requested a review from ymzayek October 25, 2023 07:44
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ymzayek ymzayek merged commit 0fa9ba3 into nilearn:main Oct 25, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the py3.7 branch October 25, 2023 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants