New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] fix typos in Harvard Oxford atlas labels #4035
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
- Coverage 91.75% 91.56% -0.19%
==========================================
Files 145 143 -2
Lines 16222 16060 -162
Branches 3370 3333 -37
==========================================
- Hits 14884 14706 -178
- Misses 795 811 +16
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can this be tested ?
yup I can at least check that labels don't end in white spaces (maybe generalizable to all atlases?) or contain some specific words. |
I think checking the white spaces can be good. IIUC the typos come from the source so it's going to be hard to thoroughly test everything except for what is reported. The fix LGTM thx! |
Maybe we should also report here: https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=fsl |
Changes proposed in this pull request: