Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] fix typos in Harvard Oxford atlas labels #4035

Merged
merged 3 commits into from Oct 13, 2023
Merged

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 7, 2023

Changes proposed in this pull request:

  • fixes typos and trailing spaces in atlas labels

@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #4035 (aeddc12) into main (7739f95) will decrease coverage by 0.19%.
Report is 9 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4035      +/-   ##
==========================================
- Coverage   91.75%   91.56%   -0.19%     
==========================================
  Files         145      143       -2     
  Lines       16222    16060     -162     
  Branches     3370     3333      -37     
==========================================
- Hits        14884    14706     -178     
- Misses        795      811      +16     
  Partials      543      543              
Flag Coverage Δ
macos-latest_3.10 91.48% <100.00%> (-0.19%) ⬇️
macos-latest_3.11 91.48% <100.00%> (-0.19%) ⬇️
macos-latest_3.12 91.48% <100.00%> (-0.19%) ⬇️
macos-latest_3.8 91.44% <100.00%> (-0.19%) ⬇️
macos-latest_3.9 91.45% <100.00%> (-0.19%) ⬇️
ubuntu-latest_3.10 91.48% <100.00%> (?)
ubuntu-latest_3.11 91.48% <100.00%> (?)
ubuntu-latest_3.12 91.48% <100.00%> (-0.19%) ⬇️
ubuntu-latest_3.8 91.44% <100.00%> (-0.19%) ⬇️
ubuntu-latest_3.9 91.45% <100.00%> (-0.19%) ⬇️
windows-latest_3.10 91.43% <100.00%> (-0.19%) ⬇️
windows-latest_3.11 91.43% <100.00%> (-0.19%) ⬇️
windows-latest_3.12 91.43% <100.00%> (-0.19%) ⬇️
windows-latest_3.8 91.39% <100.00%> (-0.19%) ⬇️
windows-latest_3.9 91.39% <100.00%> (-0.19%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nilearn/datasets/atlas.py 93.18% <100.00%> (+0.04%) ⬆️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review October 7, 2023 11:02
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this be tested ?

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Oct 9, 2023

Can this be tested ?

yup I can at least check that labels don't end in white spaces (maybe generalizable to all atlases?) or contain some specific words.

@ymzayek
Copy link
Member

ymzayek commented Oct 9, 2023

yup I can at least check that labels don't end in white spaces (maybe generalizable to all atlases?) or contain some specific words.

I think checking the white spaces can be good. IIUC the typos come from the source so it's going to be hard to thoroughly test everything except for what is reported.

The fix LGTM thx!

@ymzayek
Copy link
Member

ymzayek commented Oct 9, 2023

Maybe we should also report here: https://www.jiscmail.ac.uk/cgi-bin/webadmin?A0=fsl

@Remi-Gau Remi-Gau merged commit 38ced87 into nilearn:main Oct 13, 2023
32 checks passed
@Remi-Gau Remi-Gau deleted the ho_typo branch October 13, 2023 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Harvard-Oxford label spelling inconsistency
3 participants