Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] update URLs with http:// to https:// #4050

Merged
merged 3 commits into from Oct 13, 2023

Conversation

DimitriPapadopoulos
Copy link
Contributor

Update a large part of the URLs in the documentation.

@github-actions
Copy link
Contributor

👋 @DimitriPapadopoulos Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@ymzayek ymzayek changed the title [DOC] http:// → htps:// [DOC] http:// → https:// Oct 12, 2023
@Remi-Gau
Copy link
Collaborator

Could you do a cross check on the CITATION.cff file too. That'd be much appreciated. 😉

@codecov
Copy link

codecov bot commented Oct 12, 2023

Codecov Report

Merging #4050 (ab0dae7) into main (b6f4ff0) will increase coverage by 0.09%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4050      +/-   ##
==========================================
+ Coverage   91.48%   91.57%   +0.09%     
==========================================
  Files         143      143              
  Lines       16076    16076              
  Branches     3340     3340              
==========================================
+ Hits        14707    14722      +15     
+ Misses        823      807      -16     
- Partials      546      547       +1     
Flag Coverage Δ
macos-latest_3.10 91.47% <100.00%> (ø)
macos-latest_3.11 91.47% <100.00%> (ø)
macos-latest_3.12 91.47% <100.00%> (ø)
macos-latest_3.8 91.43% <100.00%> (ø)
macos-latest_3.9 91.43% <100.00%> (ø)
ubuntu-latest_3.10 91.47% <100.00%> (ø)
ubuntu-latest_3.11 91.47% <100.00%> (ø)
ubuntu-latest_3.12 91.47% <100.00%> (ø)
ubuntu-latest_3.8 91.43% <100.00%> (ø)
ubuntu-latest_3.9 91.43% <100.00%> (ø)
windows-latest_3.10 91.41% <100.00%> (ø)
windows-latest_3.11 91.41% <100.00%> (?)
windows-latest_3.12 91.41% <100.00%> (ø)
windows-latest_3.8 91.37% <100.00%> (ø)
windows-latest_3.9 91.38% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nilearn/datasets/atlas.py 93.18% <100.00%> (ø)
nilearn/datasets/func.py 78.66% <ø> (+0.26%) ⬆️
nilearn/datasets/neurovault.py 90.49% <ø> (ø)
nilearn/datasets/struct.py 90.85% <ø> (ø)
nilearn/decoding/proximal_operators.py 70.09% <ø> (ø)
nilearn/decoding/space_net.py 87.32% <ø> (ø)

... and 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@DimitriPapadopoulos
Copy link
Contributor Author

DimitriPapadopoulos commented Oct 12, 2023

I have not modified working http:// URLs that are not redirected to their https:// counterpart, because in that case, I think it's up to the authors to modify their URL.

Update a large part of the URLs in the documentation.
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far. Thx,

@Remi-Gau Remi-Gau changed the title [DOC] http:// → https:// [DOC] update URLs with http:// to https:// Oct 13, 2023
@DimitriPapadopoulos DimitriPapadopoulos marked this pull request as ready for review October 13, 2023 08:43
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ymzayek
Copy link
Member

ymzayek commented Oct 13, 2023

Just need to resolve the conflicts

@Remi-Gau
Copy link
Collaborator

Just need to resolve the conflicts

done

@Remi-Gau
Copy link
Collaborator

thanks @DimitriPapadopoulos

@bthirion bthirion merged commit c046058 into nilearn:main Oct 13, 2023
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants