Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix wrong indentation of example code #4053

Merged
merged 1 commit into from Oct 13, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Oct 13, 2023

  • Closes None

Just a quick thing I noticed that the example here https://nilearn.github.io/stable/development.html#guidelines-for-private-functions doesn't have the right indentations

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good with me

@github-actions
Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #4053 (96a0149) into main (b6f4ff0) will increase coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4053      +/-   ##
==========================================
+ Coverage   91.48%   91.57%   +0.09%     
==========================================
  Files         143      143              
  Lines       16076    16076              
  Branches     3340     3340              
==========================================
+ Hits        14707    14722      +15     
+ Misses        823      807      -16     
- Partials      546      547       +1     
Flag Coverage Δ
macos-latest_3.10 91.47% <ø> (ø)
macos-latest_3.11 91.47% <ø> (ø)
macos-latest_3.12 91.47% <ø> (ø)
macos-latest_3.8 91.43% <ø> (ø)
macos-latest_3.9 91.43% <ø> (ø)
ubuntu-latest_3.10 91.47% <ø> (ø)
ubuntu-latest_3.11 91.47% <ø> (ø)
ubuntu-latest_3.12 91.47% <ø> (ø)
ubuntu-latest_3.8 91.43% <ø> (ø)
ubuntu-latest_3.9 91.43% <ø> (ø)
windows-latest_3.10 91.41% <ø> (ø)
windows-latest_3.11 91.41% <ø> (?)
windows-latest_3.12 91.41% <ø> (ø)
windows-latest_3.8 91.37% <ø> (ø)
windows-latest_3.9 91.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx

@bthirion bthirion merged commit 6a7b444 into nilearn:main Oct 13, 2023
32 checks passed
@ymzayek ymzayek deleted the fix-indent branch November 7, 2023 12:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants