[MAINT] Use rng fixture for setting up np.random.RandomState() - part 2 #4054
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
October 13, 2023 18:20
ymzayek
commented
Oct 13, 2023
Comment on lines
-54
to
+57
| if sys.version_info < (3, 7): # fall back to random state for 3.6 | ||
| np.random.RandomState(42) | ||
| beta = np.random.rand(nx * ny * nz, X.shape[1]) | ||
| tseries_rand = scale(np.random.rand(nx * ny * nz, nt), axis=1) | ||
| else: | ||
| randome_state = np.random.default_rng(0) | ||
| beta = randome_state.random((nx * ny * nz, X.shape[1])) | ||
| tseries_rand = scale(randome_state.random((nx * ny * nz, nt)), axis=1) | ||
| rng = _rng() | ||
| beta = rng.random((nx * ny * nz, X.shape[1])) | ||
| tseries_rand = scale(rng.random((nx * ny * nz, nt)), axis=1) |
There was a problem hiding this comment.
Regarding this, we should actually upgrade the fixture to use np.random.default_rng
Remi-Gau
approved these changes
Oct 13, 2023
|
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4054 +/- ##
==========================================
+ Coverage 91.48% 91.60% +0.11%
==========================================
Files 143 143
Lines 16076 16072 -4
Branches 3340 3339 -1
==========================================
+ Hits 14707 14722 +15
+ Misses 823 804 -19
Partials 546 546
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 6 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
merging thenn |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
np.random.RandomState()- part 1 #4052