Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] testing minimal version of dependencies #4068

Merged
merged 21 commits into from Jan 10, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Oct 18, 2023

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1b9232c) 92.03% compared to head (725b04d) 92.09%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4068      +/-   ##
==========================================
+ Coverage   92.03%   92.09%   +0.06%     
==========================================
  Files         144      144              
  Lines       16366    16366              
  Branches     3426     3426              
==========================================
+ Hits        15062    15073      +11     
+ Misses        767      754      -13     
- Partials      537      539       +2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.89% <ø> (?)
macos-latest_3.11_test_plotting 91.89% <ø> (ø)
macos-latest_3.12_test_plotting 91.89% <ø> (ø)
macos-latest_3.8_test_plotting 91.85% <ø> (ø)
macos-latest_3.9_test_plotting 91.85% <ø> (?)
ubuntu-latest_3.10_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.11_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.12_test_plotting 91.89% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.89% <ø> (?)
ubuntu-latest_3.8_test_min 68.98% <ø> (?)
ubuntu-latest_3.8_test_plot_min 91.60% <ø> (-0.02%) ⬇️
ubuntu-latest_3.8_test_plotting 91.85% <ø> (ø)
ubuntu-latest_3.9_test_plotting 91.85% <ø> (ø)
windows-latest_3.10_test_plotting 91.86% <ø> (ø)
windows-latest_3.11_test_plotting 91.86% <ø> (ø)
windows-latest_3.12_test_plotting 91.86% <ø> (ø)
windows-latest_3.8_test_plotting 91.82% <ø> (?)
windows-latest_3.9_test_plotting 91.83% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau changed the title [IGNORE] testing minimal version for nibabel and numpy [MAINT] testing minimal version for nibabel and numpy Oct 24, 2023
@Remi-Gau Remi-Gau changed the title [MAINT] testing minimal version for nibabel and numpy [MAINT] testing minimal version of dependencies Oct 24, 2023
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

@Remi-Gau Remi-Gau marked this pull request as ready for review January 9, 2024 21:51
@Remi-Gau Remi-Gau requested a review from ymzayek January 9, 2024 21:56
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ymzayek ymzayek merged commit 6422a87 into nilearn:main Jan 10, 2024
32 checks passed
@Remi-Gau Remi-Gau deleted the nib_numpy branch January 10, 2024 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nibabel minimal dependency should be bumped up
3 participants