Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Make scope limit more obvious regarding accepting new downloaders #4080

Merged
merged 2 commits into from Oct 26, 2023

Conversation

Remi-Gau
Copy link
Collaborator

  • Closes none

Changes proposed in this pull request:

  • add a warning in the contributing doc regarding adding new downloaders

@github-actions
Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau
Copy link
Collaborator Author

@codecov
Copy link

codecov bot commented Oct 25, 2023

Codecov Report

Merging #4080 (a9596f2) into main (0fa9ba3) will decrease coverage by 0.09%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4080      +/-   ##
==========================================
- Coverage   91.59%   91.51%   -0.09%     
==========================================
  Files         143      143              
  Lines       16076    16076              
  Branches     3339     3339              
==========================================
- Hits        14725    14712      -13     
- Misses        804      819      +15     
+ Partials      547      545       -2     
Flag Coverage Δ
macos-latest_3.10 91.50% <ø> (?)
macos-latest_3.11 91.50% <ø> (?)
macos-latest_3.12 91.50% <ø> (?)
macos-latest_3.9 91.47% <ø> (?)
ubuntu-latest_3.10 91.50% <ø> (?)
ubuntu-latest_3.11 91.50% <ø> (?)
ubuntu-latest_3.12 91.50% <ø> (ø)
ubuntu-latest_3.9 91.47% <ø> (?)
windows-latest_3.10 91.46% <ø> (ø)
windows-latest_3.11 91.46% <ø> (ø)
windows-latest_3.12 91.46% <ø> (ø)
windows-latest_3.9 91.43% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Remi-Gau Remi-Gau marked this pull request as ready for review October 25, 2023 13:21
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx !

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @Remi-Gau

@Remi-Gau Remi-Gau merged commit 361afcc into nilearn:main Oct 26, 2023
29 checks passed
@Remi-Gau Remi-Gau deleted the atlas_doc branch October 26, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants