New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MAINT] Pin kaleido version to 0.1.0.post1
for windows
#4101
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov Report
@@ Coverage Diff @@
## main #4101 +/- ##
=======================================
Coverage 91.59% 91.59%
=======================================
Files 143 143
Lines 16079 16128 +49
Branches 3340 3357 +17
=======================================
+ Hits 14728 14773 +45
- Misses 804 806 +2
- Partials 547 549 +2
Flags with carried forward coverage won't be shown. Click here to find out more. see 2 files with indirect coverage changes 📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today! |
The pyproject.toml configuration works well for installing a specific version of kaleido for windows. Other systems will continue to install the most recent release. Now I'll see about launching the windows tests a number of times to see if we get any failures. |
Thanks for testing this. Glad to know my suggestion was not completely useless. I think another thing we can do it this first salvo of tests pass is to then run the problematic test a large number of times to increase our chances of triggering at least one failure. |
With commit 31c1f27 it should run 100 times for each python version on the 2 supported Actions windows runners |
Everything passed! I'll revert the changes made for testing and mark this PR as ready See https://github.com/nilearn/nilearn/actions/runs/6809985502 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good with me.
We will have enough runs of the test suite before the next release to catch any eventual fail. So let's have this one in and see if those flaky fails are gone for good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
test_plotly_savefig
time-out on GHA workflow for tests on windows #3925