Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Pin kaleido version to 0.1.0.post1 for windows #4101

Merged
merged 5 commits into from Nov 10, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Nov 8, 2023

Copy link
Contributor

github-actions bot commented Nov 8, 2023

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Merging #4101 (4ebaaab) into main (48b9267) will increase coverage by 0.00%.
Report is 3 commits behind head on main.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main    #4101   +/-   ##
=======================================
  Coverage   91.59%   91.59%           
=======================================
  Files         143      143           
  Lines       16079    16128   +49     
  Branches     3340     3357   +17     
=======================================
+ Hits        14728    14773   +45     
- Misses        804      806    +2     
- Partials      547      549    +2     
Flag Coverage Δ
macos-latest_3.10 91.51% <ø> (+<0.01%) ⬆️
macos-latest_3.11 91.51% <ø> (+<0.01%) ⬆️
macos-latest_3.12 91.51% <ø> (+<0.01%) ⬆️
macos-latest_3.9 91.47% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.10 91.51% <ø> (?)
ubuntu-latest_3.11 91.51% <ø> (+<0.01%) ⬆️
ubuntu-latest_3.12 91.51% <ø> (?)
ubuntu-latest_3.9 91.47% <ø> (+<0.01%) ⬆️
windows-latest_3.10 91.46% <ø> (+<0.01%) ⬆️
windows-latest_3.11 91.46% <ø> (+<0.01%) ⬆️
windows-latest_3.12 91.46% <ø> (?)
windows-latest_3.9 91.43% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@ymzayek
Copy link
Member Author

ymzayek commented Nov 9, 2023

The pyproject.toml configuration works well for installing a specific version of kaleido for windows. Other systems will continue to install the most recent release. Now I'll see about launching the windows tests a number of times to see if we get any failures.

@ymzayek ymzayek marked this pull request as draft November 9, 2023 08:46
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Nov 9, 2023

The pyproject.toml configuration works well for installing a specific version of kaleido for windows. Other systems will continue to install the most recent release.

Thanks for testing this. Glad to know my suggestion was not completely useless.

I think another thing we can do it this first salvo of tests pass is to then run the problematic test a large number of times to increase our chances of triggering at least one failure.

@ymzayek
Copy link
Member Author

ymzayek commented Nov 9, 2023

I think another thing we can do it this first salvo of tests pass is to then run the problematic test a large number of times to increase our chances of triggering at least one failure.

With commit 31c1f27 it should run 100 times for each python version on the 2 supported Actions windows runners

@ymzayek
Copy link
Member Author

ymzayek commented Nov 9, 2023

Everything passed! I'll revert the changes made for testing and mark this PR as ready

See https://github.com/nilearn/nilearn/actions/runs/6809985502

@ymzayek ymzayek marked this pull request as ready for review November 9, 2023 11:08
Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me.
We will have enough runs of the test suite before the next release to catch any eventual fail. So let's have this one in and see if those flaky fails are gone for good.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@ymzayek ymzayek merged commit 9ed165b into nilearn:main Nov 10, 2023
29 checks passed
@ymzayek ymzayek deleted the downgrade_kaleido branch November 10, 2023 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flaky test_plotly_savefig time-out on GHA workflow for tests on windows
3 participants