New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REF] Clarify code in find_parcellation_cut_coords
function
#4107
Conversation
ymzayek
commented
Nov 13, 2023
- Closes Refactor unclear code section #3815
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4107 +/- ##
==========================================
+ Coverage 91.63% 91.67% +0.03%
==========================================
Files 143 143
Lines 16115 16115
Branches 3353 3353
==========================================
+ Hits 14767 14773 +6
+ Misses 800 794 -6
Partials 548 548
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apparently my first review disappeared in an internet connection glitch...
So good with me and long live variables with explicit names (this is not a comment on the scope of variables)...
thanks @ymzayek