Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REF] Clarify code in find_parcellation_cut_coords function #4107

Merged
merged 2 commits into from Nov 20, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Nov 13, 2023

Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (aa9c914) 91.63% compared to head (6e7a020) 91.67%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4107      +/-   ##
==========================================
+ Coverage   91.63%   91.67%   +0.03%     
==========================================
  Files         143      143              
  Lines       16115    16115              
  Branches     3353     3353              
==========================================
+ Hits        14767    14773       +6     
+ Misses        800      794       -6     
  Partials      548      548              
Flag Coverage Δ
macos-latest_3.10 91.58% <100.00%> (+0.03%) ⬆️
macos-latest_3.11 91.58% <100.00%> (+0.03%) ⬆️
macos-latest_3.12 91.58% <100.00%> (+0.03%) ⬆️
macos-latest_3.9 91.55% <100.00%> (+0.03%) ⬆️
ubuntu-latest_3.10 91.58% <100.00%> (+0.03%) ⬆️
ubuntu-latest_3.11 91.58% <100.00%> (+0.03%) ⬆️
ubuntu-latest_3.12 91.58% <100.00%> (+0.03%) ⬆️
ubuntu-latest_3.9 91.55% <100.00%> (+0.03%) ⬆️
windows-latest_3.10 91.54% <100.00%> (+0.03%) ⬆️
windows-latest_3.11 91.54% <100.00%> (+0.03%) ⬆️
windows-latest_3.12 91.54% <100.00%> (+0.03%) ⬆️
windows-latest_3.9 91.50% <100.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM so far.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently my first review disappeared in an internet connection glitch...

So good with me and long live variables with explicit names (this is not a comment on the scope of variables)...

thanks @ymzayek

@Remi-Gau Remi-Gau merged commit e4dc5ad into nilearn:main Nov 20, 2023
29 checks passed
@ymzayek ymzayek deleted the small-refactor branch December 15, 2023 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactor unclear code section
3 participants