New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use get_tmaps=True if tmaps aren't used #4136
Conversation
👋 @crossmanith Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
==========================================
+ Coverage 91.85% 91.90% +0.05%
==========================================
Files 144 145 +1
Lines 16241 16330 +89
Branches 3386 3404 +18
==========================================
+ Hits 14918 15008 +90
+ Misses 780 778 -2
- Partials 543 544 +1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @crossmanith ! LGTM can you just accept the suggestions and then also add a whatsnew entry to doc/changes/latest.rst
and your name to CITATION.cff
? (see https://nilearn.github.io/dev/development.html#changelog for more detail)
examples/05_glm_second_level/plot_proportion_activated_voxels.py
Outdated
Show resolved
Hide resolved
examples/05_glm_second_level/plot_second_level_two_sample_test.py
Outdated
Show resolved
Hide resolved
examples/05_glm_second_level/plot_second_level_two_sample_test.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx @crossmanith !
Changes proposed in this pull request:
get_tmaps=True
from all calls tofetch_localizer_contrasts()
because tmaps aren't used in the examples.