Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use get_tmaps=True if tmaps aren't used #4136

Merged
merged 10 commits into from Dec 11, 2023

Conversation

crossmanith
Copy link
Contributor

Changes proposed in this pull request:

  • Remove get_tmaps=True from all calls to fetch_localizer_contrasts() because tmaps aren't used in the examples.

Copy link
Contributor

github-actions bot commented Dec 8, 2023

👋 @crossmanith Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 8, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0a08873) 91.85% compared to head (f471a38) 91.90%.
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4136      +/-   ##
==========================================
+ Coverage   91.85%   91.90%   +0.05%     
==========================================
  Files         144      145       +1     
  Lines       16241    16330      +89     
  Branches     3386     3404      +18     
==========================================
+ Hits        14918    15008      +90     
+ Misses        780      778       -2     
- Partials      543      544       +1     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.68% <ø> (+0.01%) ⬆️
macos-latest_3.11_test_plotting 91.68% <ø> (+0.01%) ⬆️
macos-latest_3.12_test_plotting 91.68% <ø> (+0.01%) ⬆️
macos-latest_3.8_test_plotting 91.64% <ø> (+0.01%) ⬆️
macos-latest_3.9_test_plotting 91.65% <ø> (+0.01%) ⬆️
ubuntu-latest_3.10_test_plotting 91.68% <ø> (+0.01%) ⬆️
ubuntu-latest_3.11_test_plotting 91.68% <ø> (+0.01%) ⬆️
ubuntu-latest_3.12_test_plotting 91.68% <ø> (+0.01%) ⬆️
ubuntu-latest_3.12_test_pre 91.68% <ø> (+0.01%) ⬆️
ubuntu-latest_3.8_test_min 68.88% <ø> (-0.19%) ⬇️
ubuntu-latest_3.8_test_plot_min 91.40% <ø> (+0.01%) ⬆️
ubuntu-latest_3.8_test_plotting 91.64% <ø> (+0.01%) ⬆️
ubuntu-latest_3.9_test_plotting 91.65% <ø> (+0.01%) ⬆️
windows-latest_3.10_test_plotting 91.66% <ø> (+0.01%) ⬆️
windows-latest_3.11_test_plotting 91.66% <ø> (+0.01%) ⬆️
windows-latest_3.12_test_plotting 91.66% <ø> (+0.01%) ⬆️
windows-latest_3.8_test_plotting 91.62% <ø> (+0.01%) ⬆️
windows-latest_3.9_test_plotting 91.62% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @crossmanith ! LGTM can you just accept the suggestions and then also add a whatsnew entry to doc/changes/latest.rst and your name to CITATION.cff? (see https://nilearn.github.io/dev/development.html#changelog for more detail)

crossmanith and others added 6 commits December 11, 2023 09:51
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
doc/changes/latest.rst Outdated Show resolved Hide resolved
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx @crossmanith !

@ymzayek ymzayek merged commit b892176 into nilearn:main Dec 11, 2023
32 checks passed
@crossmanith crossmanith deleted the get_tmaps branch December 11, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] Don't set get_tmaps=True if tmaps aren't used
3 participants