Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] Apply Black img_plotting.py #4147

Merged
merged 1 commit into from Dec 12, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Dec 11, 2023

Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 11, 2023

Codecov Report

Attention: 105 lines in your changes are missing coverage. Please review.

Comparison is base (f5ffeac) 91.90% compared to head (ac7a610) 68.88%.
Report is 1 commits behind head on main.

Files Patch % Lines
nilearn/plotting/img_plotting.py 0.00% 105 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #4147       +/-   ##
===========================================
- Coverage   91.90%   68.88%   -23.03%     
===========================================
  Files         145      145               
  Lines       16330    16324        -6     
  Branches     3404     3121      -283     
===========================================
- Hits        15008    11244     -3764     
- Misses        778     4654     +3876     
+ Partials      544      426      -118     
Flag Coverage Δ
macos-latest_3.10_test_plotting ?
macos-latest_3.11_test_plotting ?
macos-latest_3.12_test_plotting ?
macos-latest_3.8_test_plotting ?
macos-latest_3.9_test_plotting ?
ubuntu-latest_3.10_test_plotting ?
ubuntu-latest_3.11_test_plotting ?
ubuntu-latest_3.12_test_plotting ?
ubuntu-latest_3.12_test_pre ?
ubuntu-latest_3.8_test_min 68.88% <0.00%> (ø)
ubuntu-latest_3.8_test_plot_min ?
ubuntu-latest_3.8_test_plotting ?
ubuntu-latest_3.9_test_plotting ?
windows-latest_3.10_test_plotting ?
windows-latest_3.11_test_plotting ?
windows-latest_3.12_test_plotting ?
windows-latest_3.8_test_plotting ?
windows-latest_3.9_test_plotting ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good as well

@Remi-Gau Remi-Gau merged commit 25c456f into nilearn:main Dec 12, 2023
30 of 32 checks passed
@ymzayek ymzayek deleted the black-img-plotting branch December 12, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants