[MAINT] Improve error for nifti masker when fit is called without imgs or mask_img

[ymzayek]

• Related to [ENH] Adapt FirstLevelModel to work with surface data objects from new API #4126 (comment)

Changes proposed in this pull request:

• Raise a more meaningful error than

E TypeError: Data given cannot be loaded because it is not compatible with nibabel format:
E None

[github-actions]

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[bthirion]

LGTM.

[Remi-Gau]

Long live meaningful error messages

[Remi-Gau]

Just realized that another test is failing.

Can fix as soon as I am not a tablet.

[ymzayek]

Ok I see, so the failure has to due with order of errors basically. If we give an incorrect value to masker_strategy this will fail when _get_mask_strategy is called. I added the new error just above that so I can either move it under or change the test to pass an image object to fit.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (724cd51) 91.91% compared to head (601649b) 91.92%.
Report is 4 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #4151   +/-   ##
=======================================
  Coverage   91.91%   91.92%           
=======================================
  Files         145      145           
  Lines       16335    16337    +2     
  Branches     3406     3407    +1     
=======================================
+ Hits        15015    15017    +2     
  Misses        777      777           
  Partials      543      543           

Flag	Coverage Δ
macos-latest_3.10_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
macos-latest_3.11_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
macos-latest_3.12_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
macos-latest_3.8_test_plotting	91.66% <100.00%> (+<0.01%)	⬆️
macos-latest_3.9_test_plotting	91.66% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.10_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.11_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.12_test_plotting	91.69% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.12_test_pre	91.69% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.8_test_min	68.86% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.8_test_plot_min	91.42% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.8_test_plotting	91.66% <100.00%> (+<0.01%)	⬆️
ubuntu-latest_3.9_test_plotting	91.66% <100.00%> (+<0.01%)	⬆️
windows-latest_3.10_test_plotting	91.67% <100.00%> (+<0.01%)	⬆️
windows-latest_3.11_test_plotting	91.67% <100.00%> (+<0.01%)	⬆️
windows-latest_3.12_test_plotting	91.67% <100.00%> (+<0.01%)	⬆️
windows-latest_3.8_test_plotting	91.63% <100.00%> (+<0.01%)	⬆️
windows-latest_3.9_test_plotting	91.64% <100.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Remi-Gau]

Thanks @ymzayek