New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[INFRA] Proposal for building stable docs in remote runner for releases #4160
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4160 +/- ##
==========================================
+ Coverage 91.91% 91.93% +0.01%
==========================================
Files 145 145
Lines 16335 16360 +25
Branches 3406 3424 +18
==========================================
+ Hits 15015 15040 +25
Misses 777 777
Partials 543 543
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Would be great to have this automated!!! 😻 Let me know if you want me to check something in particular. |
Here is the succesful workflow on my fork |
whoops here it is: https://github.com/ymzayek/nilearn/actions/runs/7222661348/job/19680065387 So this should be good to go |
wait I am missing something. should your workflow run show as a new commit on the doc repo: https://github.com/nilearn/nilearn.github.io/commits/main/ ? |
@Remi-Gau not on main but on this test branch: https://github.com/nilearn/nilearn.github.io/commits/test_build/ In my repo the workflow creates a branch for testing but this is not reflected in this PR |
gotcha!! |
TODO: