New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] link surface terms to glossary #4161
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4161 +/- ##
==========================================
+ Coverage 91.84% 91.93% +0.09%
==========================================
Files 145 145
Lines 16337 16360 +23
Branches 3407 3424 +17
==========================================
+ Hits 15004 15040 +36
+ Misses 792 777 -15
- Partials 541 543 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank @Remi-Gau !
I wonder if we should add 'texture'? It's not used a lot in the docs but more so as a variable name when it equals an array projected on the surface
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
yes definitely I had listed also:
But they feel too generic, no? |
Only mentioned once: nilearn/examples/01_plotting/plot_3d_map_to_surface_projection.py:53 So maybe not? |
No strong opinion on "textures". We could also use it more frequently... |
Would suggest to merge this as is and add texture later |
Good with me. |
Changes proposed in this pull request: