New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Adjust figure size to display title for functions calling plot_surf
#4164
Conversation
👋 @ymzayek Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4164 +/- ##
==========================================
- Coverage 91.93% 91.85% -0.08%
==========================================
Files 145 145
Lines 16360 16360
Branches 3424 3424
==========================================
- Hits 15040 15027 -13
- Misses 777 788 +11
- Partials 543 545 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Seems to have fixed the problem in all examples using the relevant surf plotting functions: https://output.circle-artifacts.com/output/job/e4d6c344-b1b0-4f0b-8923-7b56934caf53/artifacts/0/dev/modules/generated/nilearn.plotting.plot_surf_stat_map.html#examples-using-nilearn-plotting-plot-surf-stat-map |
Thx ! I'd dream to have a test for that, but I guess it's ill-posed in our framework. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for the fix.
nilearn.plotting.plot_sur_stat_map
does not display the provided title #4119Changes proposed in this pull request: