Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Adjust figure size to display title for functions calling plot_surf #4164

Merged
merged 2 commits into from Dec 15, 2023

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Dec 14, 2023

Copy link
Contributor

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2d6ff1c) 91.93% compared to head (6e75330) 91.85%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4164      +/-   ##
==========================================
- Coverage   91.93%   91.85%   -0.08%     
==========================================
  Files         145      145              
  Lines       16360    16360              
  Branches     3424     3424              
==========================================
- Hits        15040    15027      -13     
- Misses        777      788      +11     
- Partials      543      545       +2     
Flag Coverage Δ
macos-latest_3.10_test_plotting ?
macos-latest_3.11_test_plotting ?
macos-latest_3.12_test_plotting 91.71% <100.00%> (ø)
macos-latest_3.8_test_plotting 91.67% <100.00%> (ø)
macos-latest_3.9_test_plotting ?
ubuntu-latest_3.11_test_plotting ?
ubuntu-latest_3.12_test_plotting ?
ubuntu-latest_3.12_test_pre ?
ubuntu-latest_3.8_test_min 68.90% <0.00%> (ø)
ubuntu-latest_3.8_test_plot_min ?
windows-latest_3.10_test_plotting 91.68% <100.00%> (ø)
windows-latest_3.11_test_plotting 91.68% <100.00%> (?)
windows-latest_3.12_test_plotting ?
windows-latest_3.8_test_plotting ?
windows-latest_3.9_test_plotting ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ymzayek
Copy link
Member Author

ymzayek commented Dec 14, 2023

@bthirion
Copy link
Member

Thx ! I'd dream to have a test for that, but I guess it's ill-posed in our framework.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for the fix.

@ymzayek
Copy link
Member Author

ymzayek commented Dec 15, 2023

Ok merging this one since it's a tiny fix

@bthirion the proposal in #4123 could maybe help a bit on this end. Other than that visually checking from time to time is necessary. It's hard to anticipate how things like this will affect rendering in the context of sphinx builds

@ymzayek ymzayek merged commit a1810e3 into nilearn:main Dec 15, 2023
32 checks passed
@ymzayek ymzayek deleted the plot_surf_titles branch December 15, 2023 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] nilearn.plotting.plot_sur_stat_map does not display the provided title
2 participants