Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INFRA] Fix auto trigger for release doc build in Actions workflow #4182

Merged
merged 1 commit into from Jan 3, 2024

Conversation

ymzayek
Copy link
Member

@ymzayek ymzayek commented Jan 2, 2024

  • Closes None

Copy link
Contributor

github-actions bot commented Jan 2, 2024

👋 @ymzayek Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c8aed35) 92.00% compared to head (624ffdd) 92.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4182   +/-   ##
=======================================
  Coverage   92.00%   92.00%           
=======================================
  Files         145      145           
  Lines       16378    16378           
  Branches     3431     3431           
=======================================
  Hits        15069    15069           
  Misses        768      768           
  Partials      541      541           
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.78% <ø> (ø)
macos-latest_3.11_test_plotting 91.78% <ø> (ø)
macos-latest_3.12_test_plotting 91.78% <ø> (ø)
macos-latest_3.8_test_plotting 91.74% <ø> (ø)
macos-latest_3.9_test_plotting 91.75% <ø> (ø)
ubuntu-latest_3.10_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.11_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.12_test_plotting 91.78% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.78% <ø> (ø)
ubuntu-latest_3.8_test_min 68.97% <ø> (ø)
ubuntu-latest_3.8_test_plot_min 91.50% <ø> (ø)
ubuntu-latest_3.8_test_plotting 91.74% <ø> (ø)
ubuntu-latest_3.9_test_plotting 91.75% <ø> (ø)
windows-latest_3.10_test_plotting 91.76% <ø> (ø)
windows-latest_3.11_test_plotting 91.76% <ø> (ø)
windows-latest_3.12_test_plotting 91.76% <ø> (ø)
windows-latest_3.8_test_plotting 91.72% <ø> (ø)
windows-latest_3.9_test_plotting 91.73% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good with me

@Remi-Gau Remi-Gau merged commit 42d70d1 into nilearn:main Jan 3, 2024
32 checks passed
@ymzayek ymzayek deleted the auto-trigger-release-build branch January 3, 2024 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants