[FIX] use parameter deprecation decorator

[Remi-Gau]

• Closes none
• Follow up on https://github.com/nilearn/nilearn/pull/4180/files#r1442751278

Changes proposed in this pull request:

• use dedicated helper decorator to deprecate parameter

[github-actions]

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (310f5ca) 92.05% compared to head (89e26d0) 92.11%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4189      +/-   ##
==========================================
+ Coverage   92.05%   92.11%   +0.06%     
==========================================
  Files         144      144              
  Lines       16374    16374              
  Branches     3426     3426              
==========================================
+ Hits        15073    15083      +10     
+ Misses        762      752      -10     
  Partials      539      539              

Flag	Coverage Δ
macos-latest_3.10_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
macos-latest_3.11_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
macos-latest_3.12_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
macos-latest_3.8_test_plotting	91.85% <100.00%> (+0.06%)	⬆️
macos-latest_3.9_test_plotting	91.86% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.10_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.11_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.12_test_plotting	91.89% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.12_test_pre	91.89% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.8_test_min	69.01% <0.00%> (ø)
ubuntu-latest_3.8_test_plot_min	91.61% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.8_test_plotting	91.85% <100.00%> (+0.06%)	⬆️
ubuntu-latest_3.9_test_plotting	91.86% <100.00%> (+0.06%)	⬆️
windows-latest_3.10_test_plotting	91.87% <100.00%> (+0.06%)	⬆️
windows-latest_3.11_test_plotting	91.87% <100.00%> (+0.06%)	⬆️
windows-latest_3.12_test_plotting	91.87% <100.00%> (+0.06%)	⬆️
windows-latest_3.8_test_plotting	91.83% <100.00%> (+0.06%)	⬆️
windows-latest_3.9_test_plotting	91.83% <100.00%> (+0.06%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[bthirion]

LGTM, thx.

[jeromedockes]

thanks @Remi-Gau ! I see we're still getting incorrect comments from codecov...