Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DEP] deprecate bids_langloc fetcher #4219

Merged
merged 5 commits into from Jan 18, 2024

Conversation

Remi-Gau
Copy link
Collaborator

Changes proposed in this pull request:

  • add deprecation warning to the bids_langloc fetcher

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Jan 16, 2024

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (281656e) 92.07% compared to head (6e7d148) 92.04%.
Report is 3 commits behind head on main.

Files Patch % Lines
nilearn/datasets/func.py 63.63% 7 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4219      +/-   ##
==========================================
- Coverage   92.07%   92.04%   -0.04%     
==========================================
  Files         144      144              
  Lines       16374    16407      +33     
  Branches     3428     3431       +3     
==========================================
+ Hits        15077    15102      +25     
- Misses        756      762       +6     
- Partials      541      543       +2     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
macos-latest_3.11_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
macos-latest_3.12_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
macos-latest_3.8_test_plotting 91.79% <69.23%> (-0.04%) ⬇️
macos-latest_3.9_test_plotting 91.80% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.10_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.11_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.12_test_plotting 91.83% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.12_test_pre 91.83% <69.23%> (?)
ubuntu-latest_3.8_test_min 68.91% <69.23%> (-0.06%) ⬇️
ubuntu-latest_3.8_test_plot_min 91.54% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.8_test_plotting 91.79% <69.23%> (-0.04%) ⬇️
ubuntu-latest_3.9_test_plotting 91.80% <69.23%> (-0.04%) ⬇️
windows-latest_3.10_test_plotting 91.81% <69.23%> (-0.04%) ⬇️
windows-latest_3.11_test_plotting 91.81% <69.23%> (-0.04%) ⬇️
windows-latest_3.12_test_plotting 91.81% <69.23%> (-0.04%) ⬇️
windows-latest_3.8_test_plotting 91.77% <69.23%> (-0.04%) ⬇️
windows-latest_3.9_test_plotting 91.78% <69.23%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Remi-Gau Remi-Gau marked this pull request as ready for review January 16, 2024 18:21
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx !

@Remi-Gau Remi-Gau requested a review from ymzayek January 17, 2024 08:03
Copy link
Member

@ymzayek ymzayek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also add a whatsnew. LGTM otherwise

nilearn/datasets/func.py Outdated Show resolved Hide resolved
Remi-Gau and others added 2 commits January 17, 2024 18:13
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
@Remi-Gau Remi-Gau merged commit da9735e into nilearn:main Jan 18, 2024
31 of 32 checks passed
@Remi-Gau Remi-Gau deleted the bids_langloc_deprec branch January 24, 2024 09:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datasets fetchers bids_langloc and language_localizer_demo seem to be getting the same data
3 participants