[FIX] Ensure that fetchers for atlas and func return a Bunch #4233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4233 +/- ##
==========================================
+ Coverage 92.04% 92.06% +0.01%
==========================================
Files 144 144
Lines 16406 16421 +15
Branches 3431 3434 +3
==========================================
+ Hits 15101 15118 +17
+ Misses 762 761 -1
+ Partials 543 542 -1 Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
Remi-Gau
commented
Jan 19, 2024
Remi-Gau
changed the title
Remi-Gau
changed the title
ymzayek
reviewed
Jan 19, 2024
Co-authored-by: Yasmin <63292494+ymzayek@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed in this pull request:
atlasandfuncfetchers return a BunchFetchers / loaders of
structwere not tested / touched as several in there just return a single nifti files.Also no test or behavior change was done to the bids_langloc as it planned for complete deprecation for 0.13.