Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] sort changelog and add highlights #4237

Merged
merged 3 commits into from Jan 26, 2024
Merged

Conversation

Remi-Gau
Copy link
Collaborator

  • Closes none

Changes proposed in this pull request:

  • add highlights and sort changelog by label

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Comment on lines +22 to +34
- :bdg-success:`API` Allow passing arguments to :func:`~nilearn.glm.first_level.first_level_from_bids` to build first level models that include specific set of confounds by relying on the strategies from :func:`~nilearn.interfaces.fmriprep.load_confounds` (:gh:`4103` by `Rémi Gau`_).

- :bdg-success:`API` Support passing t and F contrasts to :func:`~nilearn.glm.compute_contrast` that that have fewer columns than the number of estimated parameters. Remaining columns are padded with zero (:gh:`4067` by `Rémi Gau`_).

- :bdg-success:`API` :class:`~maskers.NiftiSpheresMasker` now has ``generate_report`` method (:gh:`3102` by `Yasmin Mzayek`_ and `Nicolas Gensollen`_).

- :bdg-dark:`Code` Update the ``CompCor`` strategy in :func:`~interfaces.fmriprep.load_confounds` and :func:`~interfaces.fmriprep.load_confounds_strategy` to support ``fmriprep`` 21.x series and above. (:gh:`3285` by `Hao-Ting Wang`_).

- :bdg-info:`Plotting` Allow setting ``vmin`` in :func:`~nilearn.plotting.plot_glass_brain` and :func:`~nilearn.plotting.plot_stat_map` (:gh:`3993` by `Michelle Wang`_).

- :bdg-info:`Plotting` When plotting thresholded statistical maps with a colorbar, the threshold value(s) will now be displayed as tick labels on the colorbar (:gh:`#2833` by `Nicolas Gensollen`_).

- :bdg-primary:`Doc` Combine GLM examples ``plot_fixed_effect`` and ``plot_fiac_analysis`` into a a single example ``plot_two_runs_model`` (:gh:`3191` by `Taylor Salo`_ and `Rémi Gau`_).
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

those are the things that stood out to me as worth highlighting: have a look at the content to the rest of the changelog and let me know if something else should go in.

Copy link

codecov bot commented Jan 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cfda9ff) 91.87% compared to head (efae8fa) 91.87%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4237   +/-   ##
=======================================
  Coverage   91.87%   91.87%           
=======================================
  Files         144      144           
  Lines       16421    16421           
  Branches     3434     3434           
=======================================
  Hits        15086    15086           
  Misses        792      792           
  Partials      543      543           
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.85% <ø> (ø)
macos-latest_3.11_test_plotting 91.85% <ø> (ø)
macos-latest_3.12_test_plotting 91.85% <ø> (ø)
macos-latest_3.8_test_plotting 91.81% <ø> (ø)
macos-latest_3.9_test_plotting 91.82% <ø> (ø)
ubuntu-latest_3.10_test_plotting ?
ubuntu-latest_3.11_test_plotting 91.85% <ø> (?)
ubuntu-latest_3.12_test_plotting 91.85% <ø> (ø)
ubuntu-latest_3.12_test_pre 91.85% <ø> (ø)
windows-latest_3.10_test_plotting ?
windows-latest_3.11_test_plotting ?
windows-latest_3.12_test_plotting 91.83% <ø> (ø)
windows-latest_3.8_test_plotting 91.79% <ø> (ø)
windows-latest_3.9_test_plotting 91.80% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau merged commit d0cbdcd into nilearn:main Jan 26, 2024
32 checks passed
@Remi-Gau Remi-Gau deleted the changelog branch January 26, 2024 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants