-
Notifications
You must be signed in to change notification settings - Fork 576
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] update maintenance documentation for the releases #4250
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4250 +/- ##
=======================================
Coverage 92.06% 92.06%
=======================================
Files 144 144
Lines 16419 16419
Branches 3434 3434
=======================================
Hits 15116 15116
Misses 761 761
Partials 542 542
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Bzw, I realize we don't have an example showcasing #4067
It would be good to show it otherwise we may surprise users.
So it was included when we merged the similar GLM exmaples in #3191 : Resulting examples has "short" contrasts and there is warning that will always say when the contrasts was padded. It felt right to do in this case, because the older examples did specifically include a padding function:
But you are correct that the padding is now happening "implicitly" (except for the warning) and it should probably be mentioned in the text of the example. |
check #4245 (comment) before merging |
OK, i had not realized that. Well, the warning plays its role. Note sure we need to do much more than that. |
superseded by #4371 |
Changes proposed in this pull request:
Updates to release process and its doc
git push
to push the doc to be deployed