New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] Replace remaining contrast_type
by stat_type
#4257
Conversation
👋 @larsoner Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
contrast_type
by stat_type
Looks good. Do you want to update the changelog? https://github.com/nilearn/nilearn/blob/main/doc/changes/latest.rst?plain=1 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4257 +/- ##
==========================================
+ Coverage 91.98% 92.06% +0.07%
==========================================
Files 144 144
Lines 16419 16419
Branches 3434 3434
==========================================
+ Hits 15103 15116 +13
+ Misses 776 761 -15
- Partials 540 542 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In MNE-Python I usually don't bother for small stuff like this but I can if you want me to @Remi-Gau ! |
I hear you, but if a first time contributor opened their first PR ever to fix a simple typo I think it is worth acknowledging them, so I personally prefer to have the same rule to everyone. TMK we don't have an official rule at nilearn for what constitute a minimum contribution, personally I prefer to set the bar pretty low. 😉 |
Pushed, feel free to push a commit to tweak as necessary! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thx !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thansk @larsoner
Looks like
contrast_type
was deprecated but at least one internal use was not updated tostat_type
. Discovered because I tried to follow the deprecation instructions when usingcompute_contrast
but kept getting a DeprecationWarning.