New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] read only problem with numpy 2 #4265
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4265 +/- ##
==========================================
+ Coverage 91.85% 92.06% +0.20%
==========================================
Files 144 144
Lines 16419 16421 +2
Branches 3434 3435 +1
==========================================
+ Hits 15082 15118 +36
+ Misses 792 761 -31
+ Partials 545 542 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hum, why not.
For the record this is the succesfull CI run of numpy 2 tests for this PR: https://github.com/nilearn/nilearn/actions/runs/7844973699/job/21408398473 If we get more errors on this front, I think it will be good to always run this workflow in CI rather than "switching it on and off" on every PR where we need to address numpy2 problems. |
Changes proposed in this pull request: