New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] update doc strings of the maskers #4286
Conversation
For more details on the definitions of labels in Nilearn, | ||
see the :ref:`region` section. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would be tempted (in another PR) to add label (brain region)
and maps (brain region)
(as defined in the user guide) as part of the nilearn glossary to make it easier to link to them.
Though obviously this would have to be disinguished from "statistcal maps", "class labels"...
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4286 +/- ##
==========================================
+ Coverage 91.85% 91.98% +0.12%
==========================================
Files 144 144
Lines 16419 16422 +3
Branches 3434 3436 +2
==========================================
+ Hits 15082 15106 +24
+ Misses 792 772 -20
+ Partials 545 544 -1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Changes proposed in this pull request: