New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ENH] Add avg_method
to plot_surf_stat_map
#4298
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4298 +/- ##
==========================================
+ Coverage 91.85% 92.13% +0.27%
==========================================
Files 144 143 -1
Lines 16419 16452 +33
Branches 3434 3451 +17
==========================================
+ Hits 15082 15158 +76
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
avg_method
to plot_surf_stat_map
@bthirion |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall, thx !
nilearn/plotting/surf_plotting.py
Outdated
Alpha level of the :term:`mesh` (not the stat_map). | ||
Will default to ``"auto"`` of ``None`` is passed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So, why not keeping auto
as a default ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me specify this to say this will happen only when using the matplotlib engine.
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change LGTM, thx.
avg_method
andsymmetric_cbar
flags usingplot_surf_stat_map
working properly with plotly engine #4296Changes proposed in this pull request:
avg_method
parameter toplot_surf_stat_map
None
in the function declaration and using the original default when using the matplotlib engine.