New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] use the proper html template for mutli maps and label masker #4310
Conversation
Before: see #4299 (comment) |
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4310 +/- ##
==========================================
+ Coverage 91.85% 92.13% +0.27%
==========================================
Files 144 143 -1
Lines 16419 16452 +33
Branches 3434 3451 +17
==========================================
+ Hits 15082 15158 +76
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, so this PR is only about the template ?
Co-authored-by: bthirion <bertrand.thirion@inria.fr>
yup, when investigating the root cause of #4299 turns out that report generation would not use the right template for the "multi" maskers and use the default one Still not a 100% sure why this was only affecting the multimapsmasker and not also the multilabelsmasker, but I have checked the one generated for the latter and could not spot a difference before and after we can wait till #4295 is in to do a proper check of all the maskers |
* display masker reports in doc * update changelog * refactor * add notebooks * clear cells * [full doc] request full build * add link to examples * [full doc] request full build * fix doc build
For reviewSpecifically compare and check multi label / maps maskers Before (current dev doc)
After |
Messed up the rebase. The number of line changes makes no sense. |
Note that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx !
Changes proposed in this pull request: