Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[FIX] remove conftest for externals" #4311

Merged
merged 1 commit into from Mar 6, 2024
Merged

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Mar 6, 2024

Reverts #4306
Closes #4305

Copy link
Contributor

github-actions bot commented Mar 6, 2024

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@Remi-Gau Remi-Gau marked this pull request as ready for review March 6, 2024 16:06
@Remi-Gau Remi-Gau requested a review from emdupre March 6, 2024 16:06
@bthirion
Copy link
Member

bthirion commented Mar 6, 2024

I'm a bit lost... the Numpy2 issue is something else ?

@Remi-Gau
Copy link
Collaborator Author

Remi-Gau commented Mar 6, 2024

I'm a bit lost... the Numpy2 issue is something else ?

  • Yes the numpy 2 issue (numpy 2 test workflow failures #4309) of the tests currently failing is something else (and actually probably a pandas 3.0 thing: still need to investigate).

  • I had opened Tests failing on main with pytest 8.1.0 #4305 and "fixed" because all of tests were failing when using the latests release of pytest (8.1.0). But @emdupre followed up and it seems that the latest version of pytest was bugged and got yanked from pypi and that we should not have needed the "fix" in the first place.

This PR only reverts this.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM, thx @Remi-Gau !

@Remi-Gau Remi-Gau merged commit 284a6ff into main Mar 6, 2024
30 of 31 checks passed
@Remi-Gau Remi-Gau deleted the revert-4306-fix/4305 branch March 6, 2024 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests failing on main with pytest 8.1.0
3 participants