[DOC] Adding Himanshu to authors

[man-shu]

• Closes [DOC] Add Himanshu to authors #4321

Changes proposed in this pull request:

• adding myself to authors list
• removing Yasmin (?)

[github-actions]

👋 @man-shu Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

• PR has an interpretable title.
• PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
• Code is PEP8-compliant (see our documentation on coding style)
• Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

• There is at least one unit test per new function / class (see our documentation on testing)
• The new feature is demoed in at least one relevant example.

For bug fixes:

• There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

[Remi-Gau]

make sure you also add yourself to the citation.cff file otherwise the sphinx reference for you (see below) won't be created.

`Himanshu Aggarwal`_

[man-shu]

Turns out I was already in it! Co-authored a contribution a few years ago.

[Remi-Gau]

For context:
The citation.cff is the place where we keep all our information about contributors.

If it is modified, a CI workflow will run maint_tools/citation_cff_maint.py and update some files automatically.
https://github.com/nilearn/nilearn/blob/main/.github/workflows/README.md#update-authors

This script is also run before any build of the doc in CI.

If the why or how is not clear, let me know so that we can improve the dev-facing doc.

[Remi-Gau]

Turns out I was already in it! Co-authored a contribution a few years ago.

hahaha: silly me!!!! 🙈

OK this should be good to go then.

[Remi-Gau]

something must have gone wrong on the merge with upstream because some line changes should not appear here

assuming that the central of nilearn is a remote called upstream on your local set up can you run

git fetch --all
git merge upstream/main
git push

[man-shu]

Ok so now we only have the needed changes. I'll make sure to checkout to main next time, before creating a new branch :) Sorry for the inconvenience!

[Remi-Gau]

Ok so now we only have the needed changes. I'll make sure to checkout to main next time, before creating a new branch :) Sorry for the inconvenience!

no worries at all, it still happens to me all the time!!! 😉

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.05%. Comparing base (abb80ff) to head (ad06e23).
Report is 29 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #4322      +/-   ##
==========================================
+ Coverage   91.85%   92.05%   +0.19%     
==========================================
  Files         144      143       -1     
  Lines       16419    16452      +33     
  Branches     3434     3451      +17     
==========================================
+ Hits        15082    15145      +63     
+ Misses        792      760      -32     
- Partials      545      547       +2     

Flag	Coverage Δ
macos-latest_3.11_test_plotting	?
macos-latest_3.12_test_plotting	91.92% <ø> (?)
macos-latest_3.8_test_plotting	91.88% <ø> (?)
macos-latest_3.9_test_plotting	91.89% <ø> (?)
ubuntu-latest_3.10_test_plotting	?
ubuntu-latest_3.12_test_pre	91.92% <ø> (?)
ubuntu-latest_3.8_test_min	68.81% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.