Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MAINT] add test to resampling_target = None for nifti label maskers #4336

Merged
merged 2 commits into from Mar 22, 2024

Conversation

Remi-Gau
Copy link
Collaborator

@Remi-Gau Remi-Gau commented Mar 21, 2024

Changes proposed in this pull request:

Copy link
Contributor

👋 @Remi-Gau Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.07%. Comparing base (abb80ff) to head (5b462ef).
Report is 36 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4336      +/-   ##
==========================================
+ Coverage   91.85%   92.07%   +0.21%     
==========================================
  Files         144      143       -1     
  Lines       16419    16496      +77     
  Branches     3434     3463      +29     
==========================================
+ Hits        15082    15189     +107     
+ Misses        792      764      -28     
+ Partials      545      543       -2     
Flag Coverage Δ
macos-latest_3.11_test_plotting 91.94% <ø> (+0.09%) ⬆️
macos-latest_3.12_test_plotting 91.94% <ø> (?)
macos-latest_3.8_test_plotting 91.91% <ø> (?)
ubuntu-latest_3.10_test_plotting 91.94% <ø> (+0.09%) ⬆️
ubuntu-latest_3.11_test_plotting 91.94% <ø> (?)
ubuntu-latest_3.12_test_plotting 91.94% <ø> (?)
ubuntu-latest_3.8_test_plot_min 91.61% <ø> (?)
ubuntu-latest_3.8_test_plotting 91.91% <ø> (?)
ubuntu-latest_3.9_test_plotting 91.91% <ø> (?)
windows-latest_3.10_test_plotting 91.92% <ø> (?)
windows-latest_3.11_test_plotting 91.92% <ø> (?)
windows-latest_3.12_test_plotting 91.92% <ø> (?)
windows-latest_3.8_test_plotting 91.88% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

@Remi-Gau Remi-Gau marked this pull request as ready for review March 22, 2024 13:26
@Remi-Gau Remi-Gau requested a review from man-shu March 22, 2024 13:26
@man-shu
Copy link
Contributor

man-shu commented Mar 22, 2024

Looks good to me too!

@Remi-Gau
Copy link
Collaborator Author

Okidoo. Thanks for the reviews to both. Merging.

@Remi-Gau Remi-Gau merged commit e73e8c1 into nilearn:main Mar 22, 2024
32 of 34 checks passed
@Remi-Gau Remi-Gau deleted the refactor/tests_niftilabelmaskers branch March 22, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants