New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DOC] Fix typos doc #4343
[DOC] Fix typos doc #4343
Conversation
👋 @florian6973 Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4343 +/- ##
==========================================
+ Coverage 91.85% 92.15% +0.29%
==========================================
Files 144 143 -1
Lines 16419 16496 +77
Branches 3434 3463 +29
==========================================
+ Hits 15082 15202 +120
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fix typo footcite Thirion2014
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thx for cleaning this ! this is very appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @florian6973 !
@florian6973 Unless I am mistaken you are not listed as one of our contributors. If you want you can add yourself to the list but updating the changelog and the citation.cff: |
Yes you are right, thank you very much for noticing! I edited the changelog and |
Definitely looking forward to see you contribute in the future. 🚀 |
(sorry for the wrong manipulation) |
I think that the CI failures are unrelated. Merging. |
Changes proposed in this pull request: