Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOC] Fix typos doc #4343

Merged
merged 5 commits into from Mar 29, 2024
Merged

[DOC] Fix typos doc #4343

merged 5 commits into from Mar 29, 2024

Conversation

florian6973
Copy link
Contributor

@florian6973 florian6973 commented Mar 26, 2024

  • Closes none

Changes proposed in this pull request:

  • Fix typo of the word "mutli" for the definition of MVPA in the glossary
  • Fix typo footcite Thirion2014

Copy link
Contributor

👋 @florian6973 Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.15%. Comparing base (abb80ff) to head (23884bf).
Report is 38 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4343      +/-   ##
==========================================
+ Coverage   91.85%   92.15%   +0.29%     
==========================================
  Files         144      143       -1     
  Lines       16419    16496      +77     
  Branches     3434     3463      +29     
==========================================
+ Hits        15082    15202     +120     
+ Misses        792      749      -43     
  Partials      545      545              
Flag Coverage Δ
macos-latest_3.11_test_plotting 91.94% <ø> (+0.09%) ⬆️
macos-latest_3.12_test_plotting 91.94% <ø> (?)
macos-latest_3.8_test_plotting 91.91% <ø> (?)
macos-latest_3.9_test_plotting 91.91% <ø> (?)
ubuntu-latest_3.10_test_plotting 91.94% <ø> (+0.09%) ⬆️
ubuntu-latest_3.11_test_plotting 91.94% <ø> (?)
ubuntu-latest_3.12_test_plotting 91.94% <ø> (?)
ubuntu-latest_3.8_test_min 68.83% <ø> (?)
ubuntu-latest_3.8_test_plot_min 91.61% <ø> (?)
ubuntu-latest_3.8_test_plotting 91.91% <ø> (?)
ubuntu-latest_3.9_test_plotting 91.91% <ø> (?)
windows-latest_3.10_test_plotting 91.92% <ø> (?)
windows-latest_3.11_test_plotting 91.92% <ø> (?)
windows-latest_3.12_test_plotting 91.92% <ø> (?)
windows-latest_3.8_test_plotting 91.88% <ø> (?)
windows-latest_3.9_test_plotting 91.89% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@florian6973 florian6973 changed the title Fix typo glossary MVPA Fix typos doc Mar 26, 2024
@florian6973 florian6973 changed the title Fix typos doc [DOC] Fix typos doc Mar 26, 2024
Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thx for cleaning this ! this is very appreciated.

Copy link
Member

@emdupre emdupre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @florian6973 !

@Remi-Gau
Copy link
Collaborator

@florian6973
thanks for those fixes.

Unless I am mistaken you are not listed as one of our contributors.

If you want you can add yourself to the list but updating the changelog and the citation.cff:
https://nilearn.github.io/stable/development.html#changelog

@florian6973
Copy link
Contributor Author

Yes you are right, thank you very much for noticing!

I edited the changelog and citations.cff as a result, I hope I will contribute more in the future :)

@Remi-Gau
Copy link
Collaborator

Definitely looking forward to see you contribute in the future. 🚀

@bthirion bthirion closed this Mar 28, 2024
@bthirion bthirion reopened this Mar 28, 2024
@bthirion
Copy link
Member

(sorry for the wrong manipulation)

@bthirion
Copy link
Member

I think that the CI failures are unrelated. Merging.

@bthirion bthirion merged commit eecce9a into nilearn:main Mar 29, 2024
58 of 65 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants