New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FIX] resolve numpy2 compatibility related to ambiguity when broadcasting in np.solve #4350
Conversation
👋 @Remi-Gau Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4350 +/- ##
==========================================
+ Coverage 91.85% 92.15% +0.29%
==========================================
Files 144 143 -1
Lines 16419 16496 +77
Branches 3434 3463 +29
==========================================
+ Hits 15082 15202 +120
+ Misses 792 749 -43
Partials 545 545
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The remaining failing test should be fixed by #4349. |
Numpy2 compatibility still breaks somewhere else... |
OK this fail is related to some pandas 3.0 dependency... |
Do you want to address it ? |
Sure but not in this PR. |
Changes proposed in this pull request: