Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REL 0.10.4 #4354

Merged
merged 8 commits into from Apr 9, 2024
Merged

REL 0.10.4 #4354

merged 8 commits into from Apr 9, 2024

Conversation

man-shu
Copy link
Contributor

@man-shu man-shu commented Apr 2, 2024

  • Closes none

Changes proposed in this pull request:

  • release 0.10.4, with many bug fixes
  • highlights to be discussed

@man-shu
Copy link
Contributor Author

man-shu commented Apr 2, 2024

We still need to see if we want to merge some more bug fixes before we do the release. Hence the draft state...

@man-shu man-shu requested a review from Remi-Gau April 2, 2024 14:54
Copy link
Contributor

github-actions bot commented Apr 2, 2024

👋 @man-shu Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

doc/changes/0.10.4.rst Outdated Show resolved Hide resolved
doc/changes/0.10.4.rst Outdated Show resolved Hide resolved
man-shu and others added 2 commits April 2, 2024 17:06
Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.96%. Comparing base (abb80ff) to head (bf19f97).
Report is 47 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4354      +/-   ##
==========================================
+ Coverage   91.85%   91.96%   +0.10%     
==========================================
  Files         144      143       -1     
  Lines       16419    16501      +82     
  Branches     3434     3465      +31     
==========================================
+ Hits        15082    15175      +93     
+ Misses        792      780      -12     
- Partials      545      546       +1     
Flag Coverage Δ
macos-latest_3.10_test_plotting 91.95% <ø> (?)
macos-latest_3.11_test_plotting 91.95% <ø> (+0.09%) ⬆️
macos-latest_3.8_test_plotting 91.91% <ø> (?)
macos-latest_3.9_test_plotting 91.91% <ø> (?)
ubuntu-latest_3.10_test_plotting 91.95% <ø> (+0.09%) ⬆️
ubuntu-latest_3.12_test_plotting 91.95% <ø> (?)
ubuntu-latest_3.12_test_pre 91.95% <ø> (?)
windows-latest_3.12_test_plotting 91.92% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

doc/changes/0.10.4.rst Outdated Show resolved Hide resolved
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Apr 8, 2024

The numpy2 workflow should pass. So we could proceed with the release.

@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Apr 8, 2024

will fix the merge conflict on this one

@Remi-Gau Remi-Gau marked this pull request as ready for review April 8, 2024 14:52
@Remi-Gau
Copy link
Collaborator

Remi-Gau commented Apr 8, 2024

@man-shu
I think this is ready to be merged.
Let's wait for CI to complete but then I would suggest to plan a call tomorrow morning for finalize the release.

@man-shu
Copy link
Contributor Author

man-shu commented Apr 8, 2024

Let's wait for CI to complete but then I would suggest to plan a call tomorrow morning for finalize the release.

Cool! Let's do that.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@Remi-Gau Remi-Gau merged commit 4f47301 into nilearn:main Apr 9, 2024
34 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants