New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
REL 0.10.4 #4354
REL 0.10.4 #4354
Conversation
We still need to see if we want to merge some more bug fixes before we do the release. Hence the draft state... |
👋 @man-shu Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4354 +/- ##
==========================================
+ Coverage 91.85% 91.96% +0.10%
==========================================
Files 144 143 -1
Lines 16419 16501 +82
Branches 3434 3465 +31
==========================================
+ Hits 15082 15175 +93
+ Misses 792 780 -12
- Partials 545 546 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The numpy2 workflow should pass. So we could proceed with the release. |
Co-authored-by: Remi Gau <remi_gau@hotmail.com>
will fix the merge conflict on this one |
@man-shu |
Cool! Let's do that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
Changes proposed in this pull request: