Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default clustering_percentile in _BaseDecoder docstring #4489

Merged
merged 4 commits into from
Jul 11, 2024

Conversation

man-shu
Copy link
Contributor

@man-shu man-shu commented Jul 5, 2024

Changes proposed in this pull request:

  • changing the default value of clustering_percentile in _BaseDecoder docstring from 10 to 100

@man-shu man-shu requested a review from Remi-Gau July 5, 2024 12:47
Copy link
Contributor

github-actions bot commented Jul 5, 2024

👋 @man-shu Thanks for creating a PR!

Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft.

Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.

  • PR has an interpretable title.
  • PR links to Github issue with mention Closes #XXXX (see our documentation on PR structure)
  • Code is PEP8-compliant (see our documentation on coding style)
  • Changelog or what's new entry in doc/changes/latest.rst (see our documentation on PR structure)

For new features:

  • There is at least one unit test per new function / class (see our documentation on testing)
  • The new feature is demoed in at least one relevant example.

For bug fixes:

  • There is at least one test that would fail under the original bug conditions.

We will review it as quick as possible, feel free to ping us with questions if needed.

@man-shu man-shu requested a review from bthirion July 5, 2024 12:47
Copy link

codecov bot commented Jul 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.81%. Comparing base (abb80ff) to head (d4ee544).
Report is 114 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4489      +/-   ##
==========================================
+ Coverage   91.85%   92.81%   +0.95%     
==========================================
  Files         144      147       +3     
  Lines       16419    17005     +586     
  Branches     3434     3571     +137     
==========================================
+ Hits        15082    15783     +701     
+ Misses        792      681     -111     
+ Partials      545      541       -4     
Flag Coverage Δ
macos-latest_3.10_test_plotting 92.36% <ø> (?)
macos-latest_3.11_test_plotting 92.36% <ø> (+0.50%) ⬆️
macos-latest_3.12_test_plotting 92.36% <ø> (?)
macos-latest_3.8_test_plotting 92.33% <ø> (?)
macos-latest_3.9_test_plotting 92.34% <ø> (?)
ubuntu-latest_3.10_test_plotting 92.36% <ø> (+0.50%) ⬆️
ubuntu-latest_3.11_test_plotting 92.36% <ø> (?)
ubuntu-latest_3.12_test_plotting 92.36% <ø> (?)
ubuntu-latest_3.12_test_pre 92.36% <ø> (?)
ubuntu-latest_3.8_test_min 69.07% <ø> (?)
ubuntu-latest_3.8_test_plot_min 92.04% <ø> (?)
ubuntu-latest_3.8_test_plotting 92.33% <ø> (?)
ubuntu-latest_3.9_test_plotting 92.34% <ø> (?)
windows-latest_3.10_test_plotting 92.35% <ø> (?)
windows-latest_3.11_test_plotting 92.35% <ø> (?)
windows-latest_3.12_test_plotting 92.35% <ø> (?)
windows-latest_3.8_test_plotting 92.32% <ø> (?)
windows-latest_3.9_test_plotting 92.33% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@bthirion bthirion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thx.

@man-shu
Copy link
Contributor Author

man-shu commented Jul 11, 2024

Also need a review here @Remi-Gau ! Thanks ! :)

Copy link
Collaborator

@Remi-Gau Remi-Gau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go!

Will merge right away

@Remi-Gau Remi-Gau merged commit 4412c42 into nilearn:main Jul 11, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOC] wrong default value for clustering_percentile in _BaseDecoder docstring
3 participants