-
Notifications
You must be signed in to change notification settings - Fork 581
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change default clustering_percentile
in _BaseDecoder
docstring
#4489
Conversation
👋 @man-shu Thanks for creating a PR! Until this PR is ready for review, you can include the [WIP] tag in its title, or leave it as a github draft. Please make sure it is compliant with our contributing guidelines. In particular, be sure it checks the boxes listed below.
For new features:
For bug fixes:
We will review it as quick as possible, feel free to ping us with questions if needed. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4489 +/- ##
==========================================
+ Coverage 91.85% 92.81% +0.95%
==========================================
Files 144 147 +3
Lines 16419 17005 +586
Branches 3434 3571 +137
==========================================
+ Hits 15082 15783 +701
+ Misses 792 681 -111
+ Partials 545 541 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thx.
Also need a review here @Remi-Gau ! Thanks ! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good to go!
Will merge right away
clustering_percentile
in_BaseDecoder
docstring #4488Changes proposed in this pull request:
clustering_percentile
in_BaseDecoder
docstring from 10 to 100