Added max length to single line questions

nilenso · Sep 5, 2012 · fe5d0a7 · fe5d0a7
1 parent 1e1b41e
commit fe5d0a7
Show file tree

Hide file tree

Showing 5 changed files with 10 additions and 1 deletion.
diff --git a/app/assets/javascripts/backbone/models/single_line_question_model.js.coffee b/app/assets/javascripts/backbone/models/single_line_question_model.js.coffee
@@ -7,6 +7,7 @@ class SurveyBuilder.Models.SingleLineQuestionModel extends Backbone.RelationalMo
     content: 'Untitled question'
     mandatory: false
     image: null
+    max_length: null
   }
 
   has_errors: ->

diff --git a/app/assets/javascripts/backbone/views/questions/single_line_question_view.js.coffee b/app/assets/javascripts/backbone/views/questions/single_line_question_view.js.coffee
@@ -5,6 +5,7 @@ class SurveyBuilder.Views.Questions.SingleLineQuestionView extends Backbone.View
 
   events:
     'keyup  input[type=text]': 'handle_textbox_keyup'
+    'change input[type=number]': 'handle_textbox_keyup'
     'change input[type=checkbox]': 'handle_checkbox_change'
 
   initialize: (model) ->

diff --git a/app/views/templates/questions/_single_line_question.html.erb b/app/views/templates/questions/_single_line_question.html.erb
@@ -4,6 +4,10 @@
 	<label><%= t("activerecord.attributes.question.mandatory") %> </label>
 	<input type="checkbox" name="mandatory" value="{{mandatory}}"></input>
 </div>
+<div>
+	<label><%= t("activerecord.attributes.question.max_length") %> </label>
+	<input type="number" name="max_length" value="{{max_length}}"></input>
+</div>
 <div>
 	<label><%= t("activerecord.attributes.question.image") %> </label>
 	<input type="file" name="image" accept="image/*" />

diff --git a/config/locales/en.yml b/config/locales/en.yml
@@ -7,7 +7,6 @@ en:
     sign_in: "Sign In"
     logout: "Log Out"
 
-
   flash:
     survey_created: "Survey created successfully"
     survey_deleted: "Survey deleted"

diff --git a/spec/javascripts/backbone/models/single_line_question_model_spec.js.coffee b/spec/javascripts/backbone/models/single_line_question_model_spec.js.coffee
@@ -20,6 +20,10 @@ describe "SurveyBuilder.Models.SingleLineQuestionModel", ->
       model = new SurveyBuilder.Models.SingleLineQuestionModel
       expect(model.get('image')).toBeNull
 
+    it "sets max_length to Untitled question", ->
+      model = new SurveyBuilder.Models.SingleLineQuestionModel
+      expect(model.get('max_length')).toBeNull
+
   it "should make the correct server request", ->
     model = new SurveyBuilder.Models.SingleLineQuestionModel
     spy = sinon.spy(jQuery, "ajax")