Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #14475; unittest.require now works with nim c; require and check now works with -d:nodejs #14676

Merged
merged 5 commits into from
Jul 14, 2020
Merged

fix #14475; unittest.require now works with nim c; require and check now works with -d:nodejs #14676

merged 5 commits into from
Jul 14, 2020

Conversation

timotheecour
Copy link
Member

@timotheecour timotheecour commented Jun 16, 2020 •
edited
Loading

that bug was pretty bad, and in fact fixing it reveals 2 test failures:

CI failure unrelated

@timotheecour timotheecour changed the title fix #14475; make unittest work with -d:nodejs fix #14475; unittest.require now works; unittest now works with -d:nodejs Jun 16, 2020
@timotheecour timotheecour changed the title fix #14475; unittest.require now works; unittest now works with -d:nodejs fix #14475; unittest.require now works; unittest.require and check now works with -d:nodejs Jun 16, 2020
@timotheecour timotheecour changed the title fix #14475; unittest.require now works; unittest.require and check now works with -d:nodejs fix #14475; unittest.require now works with nim c; unittest.require and check now works with -d:nodejs Jun 16, 2020
@timotheecour timotheecour changed the title fix #14475; unittest.require now works with nim c; unittest.require and check now works with -d:nodejs fix #14475; unittest.require now works with nim c; require and check now works with -d:nodejs Jun 16, 2020
This was referenced Jun 16, 2020
Closed
Closed
@timotheecour timotheecour requested a review from Araq June 16, 2020 04:54
@timotheecour timotheecour force-pushed the pr_fix_14475_unittest_require branch from b662870 to 046f9e4 Compare June 16, 2020 20:12
@timotheecour timotheecour mentioned this pull request Jun 17, 2020
Open
@timotheecour timotheecour force-pushed the pr_fix_14475_unittest_require branch from 046f9e4 to 425a293 Compare June 18, 2020 01:27
@Nycto
Copy link
Contributor

Nycto commented Jul 7, 2020

I believe Nycto/DelaunayNim#3 has been fixed -- please give it a test to confirm

@timotheecour timotheecour force-pushed the pr_fix_14475_unittest_require branch from 7bbf21e to 3cdae58 Compare July 7, 2020 20:37
@timotheecour
Copy link
Member Author

I believe Nycto/DelaunayNim#3 has been fixed -- please give it a test to confirm

done

@timotheecour
Copy link
Member Author

@Araq any other comments on this? before this PR unittest silently ignores failures

@Araq Araq merged commit e07d661 into nim-lang:devel Jul 14, 2020
@timotheecour timotheecour deleted the pr_fix_14475_unittest_require branch July 14, 2020 22:07
@timotheecour timotheecour mentioned this pull request Nov 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Clyybber Clyybber Clyybber left review comments

@Araq Araq Awaiting requested review from Araq

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

unittest require quits program with an exit code of 0
4 participants
@timotheecour @Nycto @Clyybber @Araq