Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export asyncdispatch handles #15140

Merged
merged 5 commits into from
Aug 1, 2020
Merged

export asyncdispatch handles #15140

merged 5 commits into from
Aug 1, 2020

Conversation

ringabout
Copy link
Member

I need handles attributes to make httpbeast work in windows. Now It seems to be fine to use select(windows) with httpbeast.

  let disp = getGlobalDispatcher()

  for h in disp.handles.items:
    selector.registerHandle(nativesockets.SocketHandle(h), {Event.Read},
                            initData(Dispatcher))

image

image

@Araq
Copy link
Member

Araq commented Aug 1, 2020

Document it please as an internal detail of the current implementation that might be changed.

@ringabout
Copy link
Member Author

I'm not sure which way is better? Export it or add a getIoHandles (which is specific to windows)?

@Araq
Copy link
Member

Araq commented Aug 1, 2020

I would export it. A getter doesn't help much.

@Araq Araq merged commit 3ce32a7 into nim-lang:devel Aug 1, 2020
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
* improve epoll docs

* export handles

* add comments and changelog
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants