Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added decodeQuery() to uri.nim #15345

Closed
wants to merge 6 commits into from
Closed

added decodeQuery() to uri.nim #15345

wants to merge 6 commits into from

Conversation

mrhdias
Copy link
Contributor

@mrhdias mrhdias commented Sep 16, 2020

Implements decodeQuery in uri module.

doAssert decodeQuery("") == {:}
doAssert decodeQuery("foo=bar") == {"foo": "bar"}
doAssert decodeQuery("foo=bar+%26+baz") == {"foo": "bar & baz"}
doAssert decodeQuery("foo") == {"foo": ""}

dom96
dom96 approved these changes Sep 16, 2020
View reviewed changes
Copy link
Contributor

@dom96 dom96 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I do like the symmetry. Much simpler than my implementation in #7761.

@Clyybber Clyybber mentioned this pull request Sep 18, 2020
Closed
@Clyybber
Copy link
Contributor

Clyybber commented Sep 18, 2020 •
edited

This PR was not created against devel, I'm fixing that it in #15357

@Clyybber Clyybber closed this Sep 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dom96 dom96 dom96 approved these changes

@Clyybber Clyybber Clyybber approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mrhdias @Clyybber @dom96