Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added decodeQuery() to uri.nim #15357

Closed
wants to merge 5 commits into from
Closed

added decodeQuery() to uri.nim #15357

wants to merge 5 commits into from

Conversation

Clyybber
Copy link
Contributor

This is a continuation of #15345, which wasn't created against devel.

@Clyybber Clyybber mentioned this pull request Sep 18, 2020
Closed
@Araq
Copy link
Member

Araq commented Sep 18, 2020

At least turn it into an iterator, but what's the point, cgi.decodeData already exists.

@Araq Araq closed this Sep 18, 2020
@timotheecour
Copy link
Member

at least decodeData should be mentioned in std/uri, it's not very discoverable

@dom96
Copy link
Contributor

dom96 commented Sep 22, 2020 •
edited

I think we should just move decodeData into a decodeUri in uri and make decodeData use the same call in cgi for backwards compat. The cgi module is rarely looked at/used. @Clyybber you up for doing that?

@ringabout
Copy link
Member

ringabout commented Nov 6, 2020 •
edited

cgi doesn't work in JS backend. I think decodeData should be move to std/uri.

ringabout added a commit to ringabout/Nim that referenced this pull request Nov 6, 2020
@ringabout
follow nim-lang#15357 and move decodeQuery
2059e02
@ringabout ringabout mentioned this pull request Nov 6, 2020
Merged
Araq pushed a commit that referenced this pull request Dec 27, 2020
@ringabout
follow #15357 and move decodeQuery (#15860)
6895040 
* follow #15357 and move decodeQuery
* solve problem one
* minor
* deprecate decodeData
* add changelog and since
* add testcase for decodeQuery
mildred pushed a commit to mildred/Nim that referenced this pull request Jan 11, 2021
@ringabout @mildred
follow nim-lang#15357 and move decodeQuery (nim-lang#15860)
d0d30a6 
* follow nim-lang#15357 and move decodeQuery
* solve problem one
* minor
* deprecate decodeData
* add changelog and since
* add testcase for decodeQuery
ardek66 pushed a commit to ardek66/Nim that referenced this pull request Mar 26, 2021
@ringabout @ardek66
follow nim-lang#15357 and move decodeQuery (nim-lang#15860)
7181463 
* follow nim-lang#15357 and move decodeQuery
* solve problem one
* minor
* deprecate decodeData
* add changelog and since
* add testcase for decodeQuery
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Clyybber @Araq @timotheecour @dom96 @ringabout @mrhdias