-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix #16650 #16660
fix #16650 #16660
Conversation
@@ -108,13 +104,22 @@ bar(nilstring) | |||
static: | |||
stringCompare() | |||
|
|||
# bug 8847 | |||
# issue #8847 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://nim-lang.github.io/Nim/contributing.html
Always refer to a GitHub issue using the following exact syntax: bug #1234 as shown above, so that it's consistent and easier to search or for tooling. [...]
ditto below
doAssert len(cstring"ab\0c") == 5 | ||
doAssert len(cstring("ab\0c")) == 2 | ||
when nimvm: | ||
discard |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discard | |
discard # pending bug #16555 |
if a.typ.kind == tyString: | ||
result = newIntNodeT(toInt128(a.strVal.len), n, g) | ||
elif a.typ.kind == tyCString: | ||
result = newIntNodeT(toInt128(nimCStrLen(a.strVal)), n, g) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
result = newIntNodeT(toInt128(nimCStrLen(a.strVal)), n, g) | |
result = newIntNodeT(toInt128(nimCStrLen(a.strVal)), n, g) | |
else: assert(0) |
fix #16650
Before:
After