misc cleanups

[timotheecour]

• remove {.importc.} for js types
  Add more JS stuff to dom.nim nim-lang/Nim#13483 (comment)

[timotheecour]

• compiler/extccomp.nim should use json API instead of manually writing json (eg source of bugs like koch boot fails if even an empty config.nims is present in ~/.config/nims/ [devel regression] nim-lang/Nim#13633, and less readable etc)

[timotheecour]

• make exportc imply Used for modules, see fix #13218: avoid some irrelevant warnings for nim doc,rst2html,--app:lib, + other fixes nim-lang/Nim#13550 (comment)

[timotheecour]

• Fix gdb scripts nim-lang/Nim#13658 (comment)
  => use nim program tools/nimgdb.nim exec or portable version of it

[timotheecour]

• => remove old bootstrap symbols < 0.20.0 #389

[timotheecour]

deprecate isNil

see also timotheecour/D_vs_nim#36 (comment)

Edited:
nil == something doesn't work with C or JS backend sometime.

[timotheecour]

• importcpp > importjs for js

[timotheecour]

• replace

## some ``foo``
=>
## some `foo`

everywhere in nim files since it's simpler and compat w markdown

[timotheecour]

• cleanup $nim_prs_D/tests/vm/tvmops.nim

template forceConst(a: untyped): untyped =
  ## Force evaluation at CT, useful for example here:
  ## `callFoo(forceConst(getBar1()), getBar2())`
  ## instead of:
  ##  block:
  ##    const a = getBar1()
  ##    `callFoo(a, getBar2())`
  const ret = a
  ret

=> a.static

[timotheecour]

• add to NEP https://nim-lang.org/docs/nep1.html
  it's subjectVerb, not verbSubject, eg: deprecate existsFile for fileExists

=> nim-lang#14732

[timotheecour]

• => remove old bootstrap symbols < 0.20.0 #389

[timotheecour]

• proc paramStr*(i: int): TaintedString = raise newException(OSError, "paramStr is not implemented on Genode")
  => this should be a different kind of Exception, maybe doAssert false

[timotheecour]

• (=> misc cleanups #64 (comment)))

[timotheecour]

• remove all absolute html links and replace with relative links eg:

<https://nim-lang.org/docs/lib.html#pure-libraries-modules-for-js-backend>`_

[timotheecour]

• add test case for nim js: appending a uninitialized string appends a null char '\0' nim-lang/Nim#11788
  (just the part about:

this is related to nim-lang#11783 but seems different, as the bug in nim-lang#11783 was only present when both appended and appendee were uninitialized, which isn't the case here.

var ret = "foo1"
ret.add fun()
)

[timotheecour]

• remove tyOpt
  is tyOpt still used? - Nim forum
  => replace w tyAlias from alias PR

nim-lang#14066 (comment)

By the way, what is the tyOpt type that can be found next to seq in the code?
It is a builtin "opt[T]" type, it's dead code.

[timotheecour]

• turn all code-block (which aren't being compiled/run!) into runnableExamples now that most runnableExample issues have been fixed (including multiple runnableExamples at module scope).

eg of big offender:
lib/system.nim 87
lib/pure/strutils.nim 36
lib/pure/math.nim 31

total:

as of v1.4.0: 568
as of devel 52cf7280019c943dd7df33d0dd693931e6a116ee: 500

so it's going down...
(using rg code-block: -t nim | wc -l: 500)

/cc @konsumlamm thanks for your help on this with your cleanup PR's!

[timotheecour]

• cleanup these:
  let message = "$1($2, $3) $4: $5" % [filename, $line, $col, $mc, a] (rst.nim)
  to use toLocation

[timotheecour]

• tests should use separate files, not isMainModule, see why here

move test to tests/stdlib/tsequtils.nim like most modules; rationale:

nim-lang#14413 (comment)

[timotheecour]

• doc2 => doc
  => remove all mentions of doc2, jsondoc2 (except 1 mentioning the alias) nim-lang/Nim#15683

[timotheecour]

• best practice: give warning when an iterator has multiple yield statements

$nim_prs_D/doc/contributing.rst
eg: in nimbleSubs

mentioned in https://nim-lang.github.io/Nim/manual.html#iterators-and-the-for-statement-first-class-iterators but hard to see

Caution: the body of a for loop over an inline iterator is inlined into each yield statement appearing in the iterator code, so ideally the code should be refactored to contain a single yield when possible to avoid code bloat.

[timotheecour]

deadcode

• sfIsSelf
• skConditional
• remove entries marked deadcode

[timotheecour]

• compiler/options.nim removeTrailingDirSep
  =>
  let nimblePath = normalizePathEnd(conf.nimblePaths[i].string.byLent)

with:

##[
unstable API, internal use only for now.
candidate for merging in std/decls
]##

proc byLent*[T](a: var T): lent T =
  ## caveat: see https://github.com/nim-lang/Nim/issues/14557
  ## use case: convert a var to a lent to help with overload resolution, see
  ## https://github.com/timotheecour/Nim/issues/287
  a
  

[timotheecour]

factor vmconv.elementType with typetraits.elementType

[timotheecour]

• testament:

targets: "c c++ js"
=>
targets: "c cpp js"

(only a few c++, most are cpp)

=> nim-lang#15961

[timotheecour]

• use
  include "$nim/tests/stdlib/tdecls.nim"
  instead of relative paths starting with ..
  eg

tests/stdlib/trst.nim:9:1:import ../../lib/packages/docutils/rstgen
tests/stdlib/trst.nim:10:1:import ../../lib/packages/docutils/rst
tests/stdlib/trstgen.nim:7:1:import ../../lib/packages/docutils/rstgen
tests/stdlib/trstgen.nim:8:1:import ../../lib/packages/docutils/rst
tests/stdlib/tstrutils2.nim:1:1:import "$lib/.." / compiler/strutils2
tools/grammar_nanny.nim:6:1:import ".." / compiler / [
tools/kochdocs.nim:5:1:import "../compiler/nimpaths"
tools/nimfind.nim:33:1:import "../compiler" / [options, commands, modules, sem,
tools/winrelease.nim:7:1:import "../koch"

note:

might require: nim --prefix:PATH to set the prefix path (might be more useful than --lib:lib) · Issue #365 · timotheecour/Nim

[timotheecour]

• testament: get rid of isSuccess, use exit code
  in TITLE: Testament failure with reNimcCrash - Nim forum

[timotheecour]

• change assert to doAssert in tests

EDIT: see nim-lang#16486 (comment) for remaining assert's to change

[timotheecour]

• add --styleCheck:error to tests/config.nims + whatever nim doc runs in CI and whitelist things where this doesn't work yet

[timotheecour]

• add --warningAsError to tests/config.nims + whatever nim doc runs in CI (would be made easier with implement --warningAsError:on and enforce it for compiler sources; fix some bugs with warningAsError:foo:on|off nim-lang/Nim#14068)

[timotheecour]

• code-block:: Nim in $nim_prs_D/lib/pure/htmlparser.nim is potentially dangerous
  (involves: writeFile("output.html", $html))
  and anyways should be replaced by a (non-dangerous) runnableExamples

[timotheecour]

• fix style for lib/js/jsffi.nim and /lib/std/private/*.nim

nim-lang/fusion#64 (comment)

because theres stuff with broken style on Nim main repo on /lib/js/jsffi.nim and /lib/std/private/*.nim.

[timotheecour]

• fix things like: when not defined(js) and not defined(nimdoc) which are often wrong
  and replace with: when not defined(js)

refs: nim-lang/fusion#57 (comment) and nim doc -b:js

=> fixed in nim-lang#16579

[timotheecour]

move -d:testing to tests/config.nims so it applies to all tests even ones run via exec nim inside tests

[timotheecour]

• change all these:

when not defined(js):
  {.error: "Module jsFFI is designed to be used with the JavaScript backend.".}

into these:

when not defined(js):
  {.fatal: "Module jsFFI is designed to be used with the JavaScript backend.".}

rationale: nim check (or nim r --errormax:10) will otherwise show tons of (irrelevant) errors otherwise (try with: nim check lib/js/jsre.nim)

In these case, early abort is correct.

note

ditto in similar other cases, eg with cpp instead of js etc

[timotheecour]

• refs fix #16576: honor matrix in testament by making such tests non joinable nim-lang/Nim#16577 (comment)
  document -d:nimMegatest

[ringabout]

not now

• use math.isNaN

  if (result.n[0].kind in {nkFloatLit..nkFloat64Lit} and classify(result.n[0].floatVal) == fcNan) or
      (result.n[1].kind in {nkFloatLit..nkFloat64Lit} and classify(result.n[1].floatVal) == fcNan):
    localError(c.config, n.info, "NaN is not a valid start or end for a range")

[timotheecour]

• cleanup:
  lib/pure/asynchttpserver.nim

      var (address, client) = await server.socket.acceptAddr()
      asyncCheck processClient(server, client, address, callback)

=>

      await server.acceptRequest(callback)

[timotheecour]

• address review comments in fix #16650 nim-lang/Nim#16660 that was merged

[timotheecour]

• add back at least this doc change ## and expect a reasonable result - use the isNaNorclassify procedure from closed PR promote math.isNaN nim-lang/Nim#16627

[timotheecour]

• csize=>csize_t
  eg: posix.nim(885, 29) Warning: use csize_t instead; csize is deprecated [Deprecated]

[timotheecour]

• use --warningAsError:UnusedImport in several places to avoid corresponding regressions:

• in runCI during bootstrap of nim (easy)
• in tests/config.nims (harder as may need to fix tests); note: individual tests can override via --warningAsError:UnusedImport:off, probably
• in kochdocs.nim instead of this (harder):

nimArgs = "--errormax:3 --hint:Conf:off --hint:Path:off --hint:Processing:off --hint:XDeclaredButNotUsed:off --warning:UnusedImport:off -d:boot --putenv:nimversion=$#" % system.NimVersion

[timotheecour]

• (migrated to misc cmpIgnoreStyle + friends #525)

[timotheecour]

• SOURCE_DATE_EPOCH should be removed/replaced

[timotheecour]

• move all ffi docs (and pragmas) from manual to a separate ffi_c, ffi_cpp, ffi_js rst files

refs nim-lang#16750 (comment)

[timotheecour]

• fix #16542 nim-lang/Nim#16549 (comment)

weak test, doesn't check that
hash(x) == static(hash(x)) in this branch

[timotheecour]

• 2021-02-18T07:56:46.4635833Z D:\a\1\s\lib\impure\db_sqlite.nim(184, 1) Warning: Circular dependency detected. codeReordering pragma may not be able to reorder some nodes properely [User]

https://dev.azure.com/nim-lang/255dfe86-e590-40bb-a8a2-3c0295ebdeb1/_apis/build/builds/13280/logs/99